Bug 67755

Summary:

Remove the Completion object from JSC, I have never liked it

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	barraclough: review+

Sam Weinig

Reported 2011-09-07 20:07:57 PDT

Remove the Completion object from JSC, I have never liked it

Attachments
Patch (46.10 KB, patch) 2011-09-07 20:16 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (48.57 KB, patch) 2011-09-08 09:01 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (48.76 KB, patch) 2011-09-08 09:14 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (49.25 KB, patch) 2011-09-08 10:43 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (49.32 KB, patch) 2011-09-08 13:28 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (49.77 KB, patch) 2011-09-08 14:56 PDT, Sam Weinig	barraclough: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2011-09-07 20:16:38 PDT

Created attachment 106694 [details] Patch

Sam Weinig

Comment 2 2011-09-07 20:17:12 PDT

Let's see windows crash and burn :(.

WebKit Review Bot

Comment 3 2011-09-07 20:18:52 PDT

Attachment 106694 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2011-09-07 20:32:17 PDT

Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9609827

WebKit Review Bot

Comment 5 2011-09-07 23:15:33 PDT

Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9616053

WebKit Review Bot

Comment 6 2011-09-08 00:14:39 PDT

Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9616108

Sam Weinig

Comment 7 2011-09-08 09:01:55 PDT

Created attachment 106747 [details] Patch

WebKit Review Bot

Comment 8 2011-09-08 09:04:34 PDT

Attachment 106747 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 9 2011-09-08 09:14:54 PDT

Created attachment 106748 [details] Patch

WebKit Review Bot

Comment 10 2011-09-08 09:17:56 PDT

Attachment 106748 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 11 2011-09-08 10:43:04 PDT

Created attachment 106761 [details] Patch

WebKit Review Bot

Comment 12 2011-09-08 11:09:30 PDT

Attachment 106761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 13 2011-09-08 13:28:14 PDT

Created attachment 106780 [details] Patch

WebKit Review Bot

Comment 14 2011-09-08 13:34:40 PDT

Attachment 106780 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 15 2011-09-08 14:56:19 PDT

Created attachment 106794 [details] Patch

WebKit Review Bot

Comment 16 2011-09-08 14:59:50 PDT

Attachment 106794 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 17 2011-09-08 15:08:43 PDT

Comment on attachment 106794 [details] Patch It would be nice if the inherits checks moved into helper functions (e.g. isTerminatedExecutionError()), and also if thoses classes move out of ExceptionHelpers at some point.

Sam Weinig

Comment 18 2011-09-08 15:37:42 PDT

Committed r94811: <http://trac.webkit.org/changeset/94811>

Ryosuke Niwa

Comment 19 2011-09-08 21:20:04 PDT

This patch caused two worker tests to hit assertions. See the bug 67829.

Sam Weinig

Comment 20 2011-09-08 21:53:17 PDT

(In reply to comment #19) > This patch caused two worker tests to hit assertions. See the bug 67829. Thanks, I will take a look ASAP.

Note You need to log in before you can comment on or make changes to this bug.