Bug 67755

Summary:

Remove the Completion object from JSC, I have never liked it

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	barraclough: review+

Description Sam Weinig 2011-09-07 20:07:57 PDT

Remove the Completion object from JSC, I have never liked it

Comment 1 Sam Weinig 2011-09-07 20:16:38 PDT

Created attachment 106694 [details]
Patch

Comment 2 Sam Weinig 2011-09-07 20:17:12 PDT

Let's see windows crash and burn :(.

Comment 3 WebKit Review Bot 2011-09-07 20:18:52 PDT

Attachment 106694 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:66:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:83:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Early Warning System Bot 2011-09-07 20:32:17 PDT

Comment on attachment 106694 [details]
Patch

Attachment 106694 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9609827

Comment 5 WebKit Review Bot 2011-09-07 23:15:33 PDT

Comment on attachment 106694 [details]
Patch

Attachment 106694 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9616053

Comment 6 WebKit Review Bot 2011-09-08 00:14:39 PDT

Comment on attachment 106694 [details]
Patch

Attachment 106694 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9616108

Comment 7 Sam Weinig 2011-09-08 09:01:55 PDT

Created attachment 106747 [details]
Patch

Comment 8 WebKit Review Bot 2011-09-08 09:04:34 PDT

Attachment 106747 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:66:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:83:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Sam Weinig 2011-09-08 09:14:54 PDT

Created attachment 106748 [details]
Patch

Comment 10 WebKit Review Bot 2011-09-08 09:17:56 PDT

Attachment 106748 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:66:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:83:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Sam Weinig 2011-09-08 10:43:04 PDT

Created attachment 106761 [details]
Patch

Comment 12 WebKit Review Bot 2011-09-08 11:09:30 PDT

Attachment 106761 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:66:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:83:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 Sam Weinig 2011-09-08 13:28:14 PDT

Created attachment 106780 [details]
Patch

Comment 14 WebKit Review Bot 2011-09-08 13:34:40 PDT

Attachment 106780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:66:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/JavaScriptCore/runtime/Completion.cpp:83:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Sam Weinig 2011-09-08 14:56:19 PDT

Created attachment 106794 [details]
Patch

Comment 16 WebKit Review Bot 2011-09-08 14:59:50 PDT

Attachment 106794 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1

Source/JavaScriptGlue/JavaScriptGlue.cpp:314:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/JavaScriptGlue/JavaScriptGlue.cpp:315:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 17 Gavin Barraclough 2011-09-08 15:08:43 PDT

Comment on attachment 106794 [details]
Patch

It would be nice if the inherits checks moved into helper functions (e.g. isTerminatedExecutionError()), and also if thoses classes move out of ExceptionHelpers at some point.

Comment 18 Sam Weinig 2011-09-08 15:37:42 PDT

Committed r94811: <http://trac.webkit.org/changeset/94811>

Comment 19 Ryosuke Niwa 2011-09-08 21:20:04 PDT

This patch caused two worker tests to hit assertions. See the bug 67829.

Comment 20 Sam Weinig 2011-09-08 21:53:17 PDT

(In reply to comment #19)
> This patch caused two worker tests to hit assertions. See the bug 67829.

Thanks, I will take a look ASAP.