Bug 67709

Summary: Implement double tap detection in GestureRecognizerChromium
Product: WebKit Reporter: Varun Jain <varunjain>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67645    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Varun Jain
Reported 2011-09-07 08:13:56 PDT
Implement double tap detection in GestureRecognizerChromium
Attachments
Patch (14.96 KB, patch)
2011-09-07 08:14 PDT, Varun Jain 		no flags
DetailsFormatted DiffDiff
Patch (14.78 KB, patch)
2011-09-07 12:49 PDT, Varun Jain 		no flags
DetailsFormatted DiffDiff
Patch (15.42 KB, patch)
2011-09-07 12:57 PDT, Varun Jain 		no flags
DetailsFormatted DiffDiff
Patch (15.57 KB, patch)
2011-09-08 11:57 PDT, Varun Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Varun Jain
Comment 1 2011-09-07 08:14:41 PDT
Created attachment 106585 [details] Patch
Varun Jain
Comment 2 2011-09-07 08:15:54 PDT
*** Bug 67708 has been marked as a duplicate of this bug. ***
Robert Kroeger
Comment 3 2011-09-07 11:16:47 PDT
Comment on attachment 106585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review LGTM. But you should update the patch for the intended order of committing. > Source/WebCore/platform/PlatformGestureEvent.h:42 > + DoubleTapType, this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other
Varun Jain
Comment 4 2011-09-07 12:49:13 PDT
Created attachment 106621 [details] Patch
Varun Jain
Comment 5 2011-09-07 12:55:21 PDT
(In reply to comment #3) > (From update of attachment 106585 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review > > LGTM. But you should update the patch for the intended order of committing. > > > Source/WebCore/platform/PlatformGestureEvent.h:42 > > + DoubleTapType, > > this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other Merged the other CL.
Varun Jain
Comment 6 2011-09-07 12:57:41 PDT
Created attachment 106622 [details] Patch
Varun Jain
Comment 7 2011-09-07 12:59:22 PDT
Missed the Changelog in previous patch. Uploaded new one.. PTAL
Varun Jain
Comment 8 2011-09-08 11:57:05 PDT
Created attachment 106771 [details] Patch
WebKit Review Bot
Comment 9 2011-09-08 14:10:50 PDT
Comment on attachment 106771 [details] Patch Clearing flags on attachment: 106771 Committed r94797: <http://trac.webkit.org/changeset/94797>
WebKit Review Bot
Comment 10 2011-09-08 14:10:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.