Bug 67580

Summary:

POTFILES.in/.skip need updates for translators

Product:

WebKit

Reporter:

Andre Klapper <a9016009>

Component:

WebKitGTK

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

cgarcia, cjlhomeaddress, claude, gustavo, mrobinson, piotrdrag

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	xan.lopez: review+

Andre Klapper

Reported 2011-09-04 16:37:22 PDT

http://l10n.gnome.org/module/webkit/ lists quite some issues with /po/POTFILES.in/.skip that block creating an up-to-date translation template and hence create an unneeded burden for translation contributors.

Attachments
Patch (6.97 KB, patch) 2012-10-20 23:44 PDT, Martin Robinson	xan.lopez: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Leonard

Comment 1 2012-03-22 14:44:37 PDT

This really does need to be addressed.

Chris Leonard

Comment 2 2012-08-30 19:29:38 PDT

Andre Klapper

Comment 3 2012-10-14 12:13:49 PDT

So who do I need to talk to here? Currently this makes the Epiphany browser on GNOME look rather untranslated.

Chris Leonard

Comment 4 2012-10-14 12:24:42 PDT

I think this bug is blocked by https://bugs.webkit.org/show_bug.cgi?id=45321 I've been trying to get something done about it, with no success so far. I did get Martin Robinson (webkitgtk+) talking to Claude Paroz (gnome-18n) two weeks ago , to see about a hackish fix, like the symlink one mentioned in that bug, but that conversation has gone quiet since.

Martin Robinson

Comment 5 2012-10-20 21:13:03 PDT

The first step is to fix the list of files in POTFILES (and move it to POTFILES.in for the sake of intltool). The second step is to fix intltoool-update -m, which requires changes to intltools. I think that should be enough to get Damned Lies working. If not, it should get us closer.

Martin Robinson

Comment 6 2012-10-20 23:44:31 PDT

Created attachment 169787 [details] Patch

Xan Lopez

Comment 7 2012-10-22 02:52:52 PDT

Comment on attachment 169787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169787&action=review > Source/WebKit/gtk/po/GNUmakefile.am:72 > +$(DOMAIN).pot-update: $(POTFILES) Source/WebKit/gtk/po/POTFILES Don't we want top_builddir here? Or does it have to be absolutely nothing. > Source/WebKit/gtk/po/GNUmakefile.am:87 > + --files-from=Source/WebKit/gtk/po/POTFILES \ Same question. > Source/WebKit/gtk/po/GNUmakefile.am:100 > + --files-from=Source/WebKit/gtk/po/POTFILES \ And same.

Martin Robinson

Comment 8 2012-10-22 09:26:17 PDT

(In reply to comment #7) > (From update of attachment 169787 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169787&action=review > > > Source/WebKit/gtk/po/GNUmakefile.am:72 > > +$(DOMAIN).pot-update: $(POTFILES) Source/WebKit/gtk/po/POTFILES > > Don't we want top_builddir here? Or does it have to be absolutely nothing. The build directory will always be the current directory, I believe. We make that assumption in other places, so I think we're safe omitting $(top_builddir).

Xan Lopez

Comment 9 2012-10-22 15:18:49 PDT

Comment on attachment 169787 [details] Patch Still seems safer to put the variable there; it works now but we might change the build system somehow and it would stop. Good practice to make assumptions explicit! Anyway, r+, you can change before landing.

Martin Robinson

Comment 10 2012-10-23 18:48:28 PDT

Committed r132289: <http://trac.webkit.org/changeset/132289>

claude

Comment 11 2012-10-23 23:51:35 PDT

*** Bug 45321 has been marked as a duplicate of this bug. ***

Martin Robinson

Comment 12 2012-10-27 12:22:23 PDT

*** Bug 81969 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.