Bug 67406

Summary: Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: annevk, gustavo.noronha, gustavo, rakuco, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67409    
Bug Blocks: 67400    
Attachments:
Description Flags
Patch
none
Patch webkit-ews: commit-queue-

Description Patrick R. Gansterer 2011-09-01 07:56:33 PDT 
Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-09-01 07:58:06 PDT 
Created attachment 105964 [details]
Patch
Comment 2 Gyuyoung Kim 2011-09-01 08:05:17 PDT 
Comment on attachment 105964 [details]
Patch

Attachment 105964 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9578425
Comment 3 Darin Adler 2011-09-01 09:59:13 PDT 
Comment on attachment 105964 [details]
Patch

Broke the EFL build. Need to resolve that before landing this.
Comment 4 Patrick R. Gansterer 2011-09-01 16:08:17 PDT 
Created attachment 106055 [details]
Patch
Comment 5 Early Warning System Bot 2011-09-01 16:39:55 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9581479
Comment 6 WebKit Review Bot 2011-09-01 16:52:00 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9579514
Comment 7 Gyuyoung Kim 2011-09-01 17:51:01 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9583419
Comment 8 Collabora GTK+ EWS bot 2011-09-01 23:39:34 PDT 
Comment on attachment 106055 [details]
Patch

Attachment 106055 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9582553
Comment 9 Anne van Kesteren 2023-12-28 08:30:19 PST 
This seems to have by-and-large happened, except for some instances where the Conditional attribute doesn't work.