Bug 67406

Summary: Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: annevk, gustavo.noronha, gustavo, rakuco, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67409    
Bug Blocks: 67400    
Attachments:
Description Flags
Patch
none
Patch webkit-ews: commit-queue-

Patrick R. Gansterer
Reported 2011-09-01 07:56:33 PDT
Replace ENABLE_VIDEO preprocessor statements in IDL files with Conditional attribute
Attachments
Patch (5.72 KB, patch)
2011-09-01 07:58 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2011-09-01 16:08 PDT, Patrick R. Gansterer 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-09-01 07:58:06 PDT
Created attachment 105964 [details] Patch
Gyuyoung Kim
Comment 2 2011-09-01 08:05:17 PDT
Comment on attachment 105964 [details] Patch Attachment 105964 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9578425
Darin Adler
Comment 3 2011-09-01 09:59:13 PDT
Comment on attachment 105964 [details] Patch Broke the EFL build. Need to resolve that before landing this.
Patrick R. Gansterer
Comment 4 2011-09-01 16:08:17 PDT
Created attachment 106055 [details] Patch
Early Warning System Bot
Comment 5 2011-09-01 16:39:55 PDT
Comment on attachment 106055 [details] Patch Attachment 106055 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9581479
WebKit Review Bot
Comment 6 2011-09-01 16:52:00 PDT
Comment on attachment 106055 [details] Patch Attachment 106055 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9579514
Gyuyoung Kim
Comment 7 2011-09-01 17:51:01 PDT
Comment on attachment 106055 [details] Patch Attachment 106055 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9583419
Collabora GTK+ EWS bot
Comment 8 2011-09-01 23:39:34 PDT
Comment on attachment 106055 [details] Patch Attachment 106055 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9582553
Anne van Kesteren
Comment 9 2023-12-28 08:30:19 PST
This seems to have by-and-large happened, except for some instances where the Conditional attribute doesn't work.
Note You need to log in before you can comment on or make changes to this bug.