Bug 67403

Summary: Replace ENABLE_FULLSCREEN_API preprocessor statements in IDL files with Conditional attribute
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, cmarcelo, commit-queue, esprehn+autocc, fred.wang, ojan.autocc, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67409, 67450    
Bug Blocks: 67400    
Attachments:
Description Flags
Patch
darin: review-, gyuyoung.kim: commit-queue-
Patch buildbot: commit-queue-

Patrick R. Gansterer
Reported 2011-09-01 07:50:08 PDT
Replace ENABLE_FULLSCREEN_API preprocessor statements in IDL files with Conditional attribute
Attachments
Patch (2.74 KB, patch)
2011-09-01 07:52 PDT, Patrick R. Gansterer 		darin: review-
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch (4.47 KB, patch)
2013-04-10 03:43 PDT, Patrick R. Gansterer 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-09-01 07:52:46 PDT
Created attachment 105962 [details] Patch
Gyuyoung Kim
Comment 2 2011-09-01 07:57:59 PDT
Comment on attachment 105962 [details] Patch Attachment 105962 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9582254
Early Warning System Bot
Comment 3 2011-09-01 08:04:49 PDT
Comment on attachment 105962 [details] Patch Attachment 105962 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9586010
Darin Adler
Comment 4 2011-09-01 09:58:41 PDT
Comment on attachment 105962 [details] Patch Broke the Qt and EFL builds. Need to resolve that before doing this.
Patrick R. Gansterer
Comment 5 2013-04-10 03:43:20 PDT
Created attachment 197238 [details] Patch
Build Bot
Comment 6 2013-04-10 04:02:46 PDT
Comment on attachment 197238 [details] Patch Attachment 197238 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17671047
Build Bot
Comment 7 2013-04-10 04:33:42 PDT
Comment on attachment 197238 [details] Patch Attachment 197238 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17722132
Frédéric Wang (:fredw)
Comment 8 2018-05-23 06:36:44 PDT
Source/WebCore/dom/Document.idl now uses the Conditional attribute.
Note You need to log in before you can comment on or make changes to this bug.