Bug 67267

Summary: Remove closeColorChooser call from FrameLoader::transitionToCommitted
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
added reason in changelog none

Keishi Hattori
Reported 2011-08-31 00:47:12 PDT
It was a bad place to put it. Discussed in Bug 66843 We don't need this for the chromium port.
Attachments
patch (3.62 KB, patch)
2011-08-31 01:14 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
added reason in changelog (3.68 KB, patch)
2011-08-31 18:25 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-08-31 01:14:43 PDT
Created attachment 105757 [details] patch
Kent Tamura
Comment 2 2011-08-31 01:22:20 PDT
Comment on attachment 105757 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=105757&action=review > Source/WebCore/ChangeLog:5 > + Remove closeColorChooser call from FrameLoader::transitionToCommitted > + https://bugs.webkit.org/show_bug.cgi?id=67267 > + You should write reasons of the removal in ChangeLog.
Keishi Hattori
Comment 3 2011-08-31 18:25:23 PDT
Created attachment 105875 [details] added reason in changelog
WebKit Review Bot
Comment 4 2011-08-31 18:55:43 PDT
Comment on attachment 105875 [details] added reason in changelog Clearing flags on attachment: 105875 Committed r94264: <http://trac.webkit.org/changeset/94264>
WebKit Review Bot
Comment 5 2011-08-31 18:55:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.