Summary: | [chromium] Remove obsolete child context list from LayerRendererChromium | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | enne, jbates, kbr, vangelis, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 66435 | ||||||
Attachments: |
|
Description
James Robinson
2011-08-22 18:41:08 PDT
Created attachment 104781 [details]
Patch
Comment on attachment 104781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104781&action=review My precious codez! > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:-584 > - i->first->flush(); I think this was added during Al's flush patch. Not sure if it's necessary. Seems like it should be done elsewhere anyways. That was added to replace the latch that used to be there, but we don't need to explicit flushes here at all (see the ChangeLog). Comment on attachment 104781 [details]
Patch
Glad you like it, John, but I need a WebKit reviewer to r+ or the tools will yell at me.
Ken, mind officially reviewing this?
Comment on attachment 104781 [details]
Patch
Looks good as long as it's been tested with various content to ensure that the flushes being removed aren't necessary.
Comment on attachment 104781 [details] Patch Clearing flags on attachment: 104781 Committed r93647: <http://trac.webkit.org/changeset/93647> All reviewed patches have been landed. Closing bug. |