| Summary: | [skia] -webkit-transform breaks -webkit-mask | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Wells <benwells> | ||||||
| Component: | Layout and Rendering | Assignee: | Ben Wells <benwells> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jamesr, kbr, mikelawther, reed, senorblanco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ben Wells
2011-08-17 18:15:38 PDT
Created attachment 104296 [details]
Patch
Created attachment 104297 [details]
Test case from crbug.com
This looks good, but have you run the full layout test suite? Does this patch will change any results on other tests (hopefully for the better)? For example, I'm wondering if this may be why our SVG masks results are wrong, e.g., crbug.com/3244. I have run all the tests and there is no difference. SVG tests in particular seem to be equally broken, there is no improvement for the testcases on webkit bug 64237 or bug 44278, or for http://crbug.com/3244. I think the svg stuff might do the masking in other ways and have other problems. Looking at WebCore/rendering/svg/SVGImageBufferTools.cpp SVGImageBufferTools::renderSubtreeToImageBuffer it uses context.clipToImageBuffer (which seems to be used for bug 642367). I haven't investigated SVG further than this. There could be some other new non-svg passes which are hidden by font or other platform differences - I only noticed the transformed-mask.html included in the patch by accident when going to add a new test that had a similar name. I just generated a list of tests which are marked as fails which have webkit-mask or webkit-transform, there is quite a few but I'll check them out to see if we've got any new passes. Comment on attachment 104296 [details]
Patch
Looks good. Mike Reed should probably take a look at this when he gets back. r=me
Thanks for the review. I found two more tests which should pass, I'll rebaseline them once this has landed and had time to generate some results. Comment on attachment 104296 [details] Patch Clearing flags on attachment: 104296 Committed r93386: <http://trac.webkit.org/changeset/93386> All reviewed patches have been landed. Closing bug. |