Bug 66236

Summary: Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, dglazkov, ericu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65787    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-08-15 09:34:36 PDT
Many FileAPI-related functions changed. See https://bugs.webkit.org/show_bug.cgi?id=64539 for the IDL change.
Attachments
Patch (6.70 KB, patch)
2011-10-06 19:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.46 KB, patch)
2011-10-07 08:55 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-06 10:01:42 PDT
These are the APIs that appear to have changed: DirectoryReader.readEntries Entry.moveTo Entry.copyTo EntryArray.item EntryArraySync.item EntrySync.moveTo EntrySync.copyTo FileEntry.createWriter FileEntry.file FileList.item FileReader.readAsArrayBuffer FileReader.readAsBinaryString FileReader.readAsText FileReader.readAsDataURL FileReaderSync.readAsArrayBuffer FileReaderSync.readAsBinaryString FileReaderSync.readAsText FileReaderSync.readAsDataURL FileWriter.write FileWriter.seek FileWriter.truncate FileWriterSync.write FileWriterSync.seek FileWriterSync.truncate WebKitBlobBuilder.append
Adam Barth
Comment 2 2011-10-06 19:51:39 PDT
Created attachment 110081 [details] Patch
WebKit Review Bot
Comment 3 2011-10-06 20:55:43 PDT
Comment on attachment 110081 [details] Patch Attachment 110081 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10010075 New failing tests: fast/files/not-enough-arguments.html
Adam Barth
Comment 4 2011-10-06 22:10:59 PDT
Comment on attachment 110081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110081&action=review > LayoutTests/fast/files/not-enough-arguments-expected.txt:17 > +#EOF Oops. This is raw DRT output. :)
Adam Barth
Comment 5 2011-10-07 08:55:52 PDT
Created attachment 110153 [details] Patch
WebKit Review Bot
Comment 6 2011-10-07 10:20:02 PDT
Comment on attachment 110153 [details] Patch Clearing flags on attachment: 110153 Committed r96956: <http://trac.webkit.org/changeset/96956>
WebKit Review Bot
Comment 7 2011-10-07 10:20:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.