Bug 66173 – [Qt] Add eventSender.gestureTap

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

r92997 added new eventSender method: gestureTap.  Qt should implement this feature.

[Sadrul Habib Chowdhury]

Created attachment 103830 [details]
fix

[Sadrul Habib Chowdhury]

The fast/event/touch tests are already skipped in other platforms (e.g. win, mac, gtk)

[Ryosuke Niwa]

Comment on attachment 103830 [details]
fix

I'm adding the test to the Qt's skipped list for now.  This patch isn't going to fix this bug because it doesn't actually implement the eventSender method.

[Ryosuke Niwa]

The test skipped in http://trac.webkit.org/changeset/93006.

[Allan Sandfeld Jensen]

Created attachment 128237 [details]
Patch

[WebKit Review Bot]

Comment on attachment 128237 [details]
Patch

Clearing flags on attachment: 128237

Committed r108577: <http://trac.webkit.org/changeset/108577>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Allan Sandfeld Jensen]

The patch did not implement the tap gesture in a functional way, and I am not sure we want to implement it since it is completely absent from the WebKitTestRunner.

[Allan Sandfeld Jensen]

Created attachment 164729 [details]
Patch

[WebKit Review Bot]

Comment on attachment 164729 [details]
Patch

Clearing flags on attachment: 164729

Committed r129102: <http://trac.webkit.org/changeset/129102>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Allan Sandfeld Jensen]

The implemenatation lacked handling of the GestureEvent in WebKit code. I missed this for the second time, because the default expected result of the test-case is actually a fail.

[Allan Sandfeld Jensen]

Created attachment 165132 [details]
Patch2

[WebKit Review Bot]

Attachment 165132 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebKit/qt/Api/qwebpage.cpp:98:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebpage.cpp:136:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Hausmann]

Comment on attachment 165132 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review

r=me but needs #include order fix before landing I suppose :)

> Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322
> +        m_position = event->widget()->mapFromGlobal(globalPos.toPoint());

With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :)

[Allan Sandfeld Jensen]

(In reply to comment #15)
> (From update of attachment 165132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review
> 
> r=me but needs #include order fix before landing I suppose :)
> 
> > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322
> > +        m_position = event->widget()->mapFromGlobal(globalPos.toPoint());
> 
> With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :)

But wouldn't QtWebKit(1) be in QtWebKitWidgets, and therefore allowed to depend on Widget code?

[Allan Sandfeld Jensen]

Committed in r132052

[Allan Sandfeld Jensen]

Comment on attachment 165132 [details]
Patch2

Clearing flags