Summary: | Make EventDispatchMediator refcounted. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | UI Events | Assignee: | Hayato Ito <hayato> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dominicc, morrita, rolandsteiner, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 65593 | ||||||||
Bug Blocks: | 64249 | ||||||||
Attachments: |
|
Description
Hayato Ito
2011-08-02 05:17:25 PDT
Created attachment 102636 [details]
make EventDispatchMediator refcounted
Comment on attachment 102636 [details]
make EventDispatchMediator refcounted
ok. I initially imagined DispatchMediator to be a simple wrapper, but it does make sense that we should be able to stash it away for scoped events.
Committed r92256: <http://trac.webkit.org/changeset/92256> Created attachment 102743 [details]
fix chromium win builds
https://bugs.webkit.org/attachment.cgi?id=102636 caused tons of crashes on the chromium win bots. See https://bugs.webkit.org/show_bug.cgi?id=65593. Although I am not 100% sure why that failed only on chromium win bots, I guess the root cause is this terrible mistake: class EventDispatchMediator : public RefCounted<Event> I've fixed it. I've confirmed that chromium win bots didn't fail this time. http://build.chromium.org/p/tryserver.chromium/builders/win/builds/46529 Comment on attachment 102743 [details]
fix chromium win builds
Let's see what happens
Comment on attachment 102743 [details] fix chromium win builds Clearing flags on attachment: 102743 Committed r92266: <http://trac.webkit.org/changeset/92266> All reviewed patches have been landed. Closing bug. |