Bug 65529

Summary: Make EventDispatchMediator refcounted.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, rolandsteiner, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 65593    
Bug Blocks: 64249    
Attachments:
Description Flags
make EventDispatchMediator refcounted
none
fix chromium win builds none

Hayato Ito
Reported 2011-08-02 05:17:25 PDT
This patch is one of the separated patches from bug 62429. Make EventDispatchMediator refCounted so that it can be enqueued into a ScopedEventQueue and called later. A necessary change for ScopedEventQueue should be addressed in another patch.
Attachments
make EventDispatchMediator refcounted (10.77 KB, patch)
2011-08-02 05:22 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
fix chromium win builds (10.79 KB, patch)
2011-08-02 23:27 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2011-08-02 05:19:22 PDT
s/ bug 62429 / bug 64249 /.
Hayato Ito
Comment 2 2011-08-02 05:22:32 PDT
Created attachment 102636 [details] make EventDispatchMediator refcounted
Dimitri Glazkov (Google)
Comment 3 2011-08-02 09:21:40 PDT
Comment on attachment 102636 [details] make EventDispatchMediator refcounted ok. I initially imagined DispatchMediator to be a simple wrapper, but it does make sense that we should be able to stash it away for scoped events.
Hayato Ito
Comment 4 2011-08-02 20:26:39 PDT
Committed r92256: <http://trac.webkit.org/changeset/92256>
Hayato Ito
Comment 5 2011-08-02 23:27:39 PDT
Created attachment 102743 [details] fix chromium win builds
Hayato Ito
Comment 6 2011-08-02 23:50:15 PDT
https://bugs.webkit.org/attachment.cgi?id=102636 caused tons of crashes on the chromium win bots. See https://bugs.webkit.org/show_bug.cgi?id=65593. Although I am not 100% sure why that failed only on chromium win bots, I guess the root cause is this terrible mistake: class EventDispatchMediator : public RefCounted<Event> I've fixed it.
Hayato Ito
Comment 7 2011-08-03 01:38:05 PDT
I've confirmed that chromium win bots didn't fail this time. http://build.chromium.org/p/tryserver.chromium/builders/win/builds/46529
Hajime Morrita
Comment 8 2011-08-03 01:41:24 PDT
Comment on attachment 102743 [details] fix chromium win builds Let's see what happens
WebKit Review Bot
Comment 9 2011-08-03 03:17:46 PDT
Comment on attachment 102743 [details] fix chromium win builds Clearing flags on attachment: 102743 Committed r92266: <http://trac.webkit.org/changeset/92266>
WebKit Review Bot
Comment 10 2011-08-03 03:17:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.