Bug 65162

Summary: Add an exception to coding style check for EFL port
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65163    
Attachments:
Description Flags
Proposed Patch none

Gyuyoung Kim
Reported 2011-07-25 21:13:04 PDT
In EFL coding style, '*' operator is next to variable instead of data type. I think it is better to adhere the rule in efl port because port implementation tends to be in the style of the embedding system.
Attachments
Proposed Patch (1.18 KB, patch)
2011-07-25 21:14 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-07-25 21:14:07 PDT
Created attachment 101967 [details] Proposed Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-07-26 05:13:47 PDT
LGTM
Gyuyoung Kim
Comment 3 2011-07-26 18:10:48 PDT
CC'ing Eric, tkent, Could you please review this patch ? Sorry for adding CC. But, it was difficult to find proper reviewers.
Kent Tamura
Comment 4 2011-07-26 18:46:32 PDT
Comment on attachment 101967 [details] Proposed Patch ok
WebKit Review Bot
Comment 5 2011-07-26 19:02:53 PDT
Comment on attachment 101967 [details] Proposed Patch Clearing flags on attachment: 101967 Committed r91810: <http://trac.webkit.org/changeset/91810>
WebKit Review Bot
Comment 6 2011-07-26 19:02:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.