Summary: | Switch to use Python enumerate function to enumerate line numbers. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 64385, 64605 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2011-07-15 09:32:19 PDT
Created attachment 100994 [details]
Patch
Comment on attachment 100994 [details]
Patch
Is this correctly one/zero based? Looks like the old code was 1-based but I would have expected enumerate to be 0-based.
(In reply to comment #2) > (From update of attachment 100994 [details]) > Is this correctly one/zero based? Looks like the old code was 1-based but I would have expected enumerate to be 0-based. enumerate is indeed 0-based. That's why I have the start=1 parameter. Comment on attachment 100994 [details] Patch Clearing flags on attachment: 100994 Committed r91091: <http://trac.webkit.org/changeset/91091> All reviewed patches have been landed. Closing bug. Comment on attachment 100994 [details]
Patch
Ok. I'm blind.
Reverted in http://trac.webkit.org/changeset/91106, after breaking lotsa tests on Leopard. |