Bug 64590

Summary: Printing of notImplemented() when logging enabled
Product: WebKit Reporter: Lukasz Slachciak <l.slachciak>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 63346    
Bug Blocks:    
Attachments:
Description Flags
notImplemented function patch none

Lukasz Slachciak
Reported 2011-07-15 03:16:53 PDT
Printing of notImplemented() method was enabled on Debug builds only. Now it is enabled when logging is enabled
Attachments
notImplemented function patch (1.17 KB, patch)
2011-07-15 03:22 PDT, Lukasz Slachciak 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lukasz Slachciak
Comment 1 2011-07-15 03:22:51 PDT
Created attachment 100952 [details] notImplemented function patch
Eric Seidel (no email)
Comment 2 2011-09-12 17:02:10 PDT
Comment on attachment 100952 [details] notImplemented function patch I'm confused. Will this result in a situation where notImplemented is not defined? Or was it always defined and just re-defined by this #define in situations where we didn't use it?
WebKit Review Bot
Comment 3 2011-09-23 20:19:59 PDT
Comment on attachment 100952 [details] notImplemented function patch Clearing flags on attachment: 100952 Committed r95898: <http://trac.webkit.org/changeset/95898>
WebKit Review Bot
Comment 4 2011-09-23 20:20:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.