WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63346
Change NDEBUG to !LOG_DISABLED macro in databases for logging.
https://bugs.webkit.org/show_bug.cgi?id=63346
Summary
Change NDEBUG to !LOG_DISABLED macro in databases for logging.
Lukasz Slachciak
Reported
2011-06-24 13:27:34 PDT
Changed NDEBUG to !LOG_DISABLED in databases code which involves logging. This change resolves also build break in Release build when logging enabled.
Attachments
Logging in databases patch
(9.61 KB, patch)
2011-06-24 13:32 PDT
,
Lukasz Slachciak
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Lukasz Slachciak
Comment 1
2011-06-24 13:32:12 PDT
Created
attachment 98528
[details]
Logging in databases patch
WebKit Review Bot
Comment 2
2011-06-24 15:04:42 PDT
The commit-queue encountered the following flaky tests while processing
attachment 98528
[details]
: http/tests/local/formdata/upload-events.html
bug 63357
(author:
jianli@chromium.org
) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 3
2011-06-24 15:07:22 PDT
Comment on
attachment 98528
[details]
Logging in databases patch Clearing flags on attachment: 98528 Committed
r89708
: <
http://trac.webkit.org/changeset/89708
>
WebKit Review Bot
Comment 4
2011-06-24 15:07:26 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug