Bug 63346 - Change NDEBUG to !LOG_DISABLED macro in databases for logging.
Summary: Change NDEBUG to !LOG_DISABLED macro in databases for logging.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 64590
  Show dependency tree / graph
 
Reported: 2011-06-24 13:27 PDT by Lukasz Slachciak
Modified: 2011-07-15 11:33 PDT (History)
2 users (show)

See Also:

Attachments
Logging in databases patch (9.61 KB, patch)
2011-06-24 13:32 PDT, Lukasz Slachciak 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Slachciak 2011-06-24 13:27:34 PDT 
Changed NDEBUG to !LOG_DISABLED in databases code which involves logging. This change resolves also build break in Release build when logging enabled.
Comment 1 Lukasz Slachciak 2011-06-24 13:32:12 PDT 
Created attachment 98528 [details]
Logging in databases patch
Comment 2 WebKit Review Bot 2011-06-24 15:04:42 PDT 
The commit-queue encountered the following flaky tests while processing attachment 98528 [details]:

http/tests/local/formdata/upload-events.html bug 63357 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Review Bot 2011-06-24 15:07:22 PDT 
Comment on attachment 98528 [details]
Logging in databases patch

Clearing flags on attachment: 98528

Committed r89708: <http://trac.webkit.org/changeset/89708>
Comment 4 WebKit Review Bot 2011-06-24 15:07:26 PDT 
All reviewed patches have been landed.  Closing bug.