Bug 64590 - Printing of notImplemented() when logging enabled
Summary: Printing of notImplemented() when logging enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 63346
Blocks:
  Show dependency tree / graph
 
Reported: 2011-07-15 03:16 PDT by Lukasz Slachciak
Modified: 2011-09-23 20:20 PDT (History)
1 user (show)

See Also:

Attachments
notImplemented function patch (1.17 KB, patch)
2011-07-15 03:22 PDT, Lukasz Slachciak 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Slachciak 2011-07-15 03:16:53 PDT 
Printing of notImplemented() method was enabled on Debug builds only. Now it is enabled when logging is enabled
Comment 1 Lukasz Slachciak 2011-07-15 03:22:51 PDT 
Created attachment 100952 [details]
notImplemented function patch
Comment 2 Eric Seidel (no email) 2011-09-12 17:02:10 PDT 
Comment on attachment 100952 [details]
notImplemented function patch

I'm confused.  Will this result in a situation where notImplemented is not defined?  Or was it always defined and just re-defined by this #define in situations where we didn't use it?
Comment 3 WebKit Review Bot 2011-09-23 20:19:59 PDT 
Comment on attachment 100952 [details]
notImplemented function patch

Clearing flags on attachment: 100952

Committed r95898: <http://trac.webkit.org/changeset/95898>
Comment 4 WebKit Review Bot 2011-09-23 20:20:04 PDT 
All reviewed patches have been landed.  Closing bug.