Bug 64512

Summary: Move scalePageBy from eventSender to window.internals
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bdakin, fsamuel, gustavo.noronha, gustavo, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=75965
Bug Depends on: 74069    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Simon Fraser (smfr)
Reported 2011-07-13 22:45:58 PDT
eventSender doesn't seem like the right place form scalePageBy(). It should move to window.internal now.
Attachments
Patch (29.46 KB, patch)
2011-12-02 15:49 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (31.52 KB, patch)
2011-12-02 23:31 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (32.80 KB, patch)
2011-12-03 07:55 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (32.97 KB, patch)
2011-12-07 13:46 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.87 KB, patch)
2011-12-08 00:02 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.01 KB, patch)
2012-01-05 08:27 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-12-02 08:45:31 PST
I'd like to do this for setting fixed layout as well. There's a bunch of layout tests that need changing, and then a lot of platform-specific code that needs to be removed. I'll add a copy of scalePageBy to window.internals, and then we can delete platform specific code as a separate patch or let each port deal with that on their own.
Fady Samuel
Comment 2 2011-12-02 15:49:18 PST
Created attachment 117708 [details] Patch
Fady Samuel
Comment 3 2011-12-02 15:50:24 PST
I've restricted the scope of this patch to just setPageScaleFactor. I will add deviceScaleFactor and and fixed layout in a subsequent bug report.
Collabora GTK+ EWS bot
Comment 4 2011-12-02 22:25:01 PST
Comment on attachment 117708 [details] Patch Attachment 117708 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10725675
Fady Samuel
Comment 5 2011-12-02 23:31:51 PST
Created attachment 117745 [details] Patch
Collabora GTK+ EWS bot
Comment 6 2011-12-03 03:16:18 PST
Comment on attachment 117745 [details] Patch Attachment 117745 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10732247
Fady Samuel
Comment 7 2011-12-03 07:55:32 PST
Created attachment 117758 [details] Patch
Simon Fraser (smfr)
Comment 8 2011-12-07 12:10:17 PST
Comment on attachment 117758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review > Source/WebCore/testing/Internals.idl:83 > + float getPageScaleFactor(in Document document) raises(DOMException); We don't normally use 'get' in getters.
Fady Samuel
Comment 9 2011-12-07 13:46:19 PST
Created attachment 118269 [details] Patch
Fady Samuel
Comment 10 2011-12-07 13:47:36 PST
(In reply to comment #8) > (From update of attachment 117758 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117758&action=review > > > Source/WebCore/testing/Internals.idl:83 > > + float getPageScaleFactor(in Document document) raises(DOMException); > > We don't normally use 'get' in getters. Fixed, submitted a patch to get the updated symbols from the various EWS bots, then will land.
Fady Samuel
Comment 11 2011-12-08 00:02:40 PST
Created attachment 118341 [details] Patch for landing
WebKit Review Bot
Comment 12 2011-12-08 01:18:19 PST
Comment on attachment 118341 [details] Patch for landing Clearing flags on attachment: 118341 Committed r102323: <http://trac.webkit.org/changeset/102323>
WebKit Review Bot
Comment 13 2011-12-08 01:18:26 PST
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 14 2011-12-08 06:44:43 PST
*** Bug 59098 has been marked as a duplicate of this bug. ***
Fady Samuel
Comment 15 2011-12-08 08:49:34 PST
Attempting to reland this (I don' believe this broke the build given the green EWS) If things break, I'm around to figure out what the problem is.
Fady Samuel
Comment 16 2012-01-05 08:16:25 PST
This should land, I'm not sure if it broke anything? Checking again now.
Fady Samuel
Comment 17 2012-01-05 08:27:20 PST
Created attachment 121282 [details] Patch for landing
WebKit Review Bot
Comment 18 2012-01-05 10:17:03 PST
Comment on attachment 121282 [details] Patch for landing Clearing flags on attachment: 121282 Committed r104174: <http://trac.webkit.org/changeset/104174>
WebKit Review Bot
Comment 19 2012-01-05 10:17:09 PST
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 20 2012-01-10 08:12:56 PST
This seems to have caused bug 75965.
Note You need to log in before you can comment on or make changes to this bug.