Bug 64488

Summary: Fix WTF header guard style check
Product: WebKit Reporter: Ilya Sherman <isherman>
Component: New BugsAssignee: Ilya Sherman <isherman>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, isherman, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ilya Sherman
Reported 2011-07-13 15:15:09 PDT
Fix WTF header guard style check
Attachments
Patch (1.23 KB, patch)
2011-07-13 15:15 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2011-07-13 16:18 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Sherman
Comment 1 2011-07-13 15:15:32 PDT
Created attachment 100719 [details] Patch
David Levin
Comment 2 2011-07-13 15:25:39 PDT
Comment on attachment 100719 [details] Patch A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it).
Ilya Sherman
Comment 3 2011-07-13 16:18:19 PDT
Created attachment 100727 [details] Patch
Ilya Sherman
Comment 4 2011-07-13 16:19:24 PDT
(In reply to comment #2) > (From update of attachment 100719 [details]) > A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it). Added a test. This was patch was originally motivated by a false-positive style warning for https://bugs.webkit.org/show_bug.cgi?id=64333
David Levin
Comment 5 2011-07-13 16:21:59 PDT
Comment on attachment 100727 [details] Patch Oh of course. Thanks!
WebKit Review Bot
Comment 6 2011-07-13 16:45:31 PDT
Comment on attachment 100727 [details] Patch Clearing flags on attachment: 100727 Committed r90965: <http://trac.webkit.org/changeset/90965>
WebKit Review Bot
Comment 7 2011-07-13 16:45:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.