Bug 64413

Summary: Rename FloatRect/Point/Size and move them to an abstraction
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, eae, eric, hyatt, mitz, mjs, peter, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64754    
Bug Blocks: 63567, 64405    
Attachments:
Description Flags
Rev 1, Mac only
none
Trying Again
none
Patch
none
Patch
none
Patch none

Description Levi Weintraub 2011-07-12 17:31:34 PDT 
We may want to use something other than floats for the various graphics structures on different platforms -- namely CGFloat on Mac  -- so renaming the floating point graphics structures  to something more generic. I recommend "Graphics*": GraphicsUnit, GraphicsPoint, GraphicsSize, and GraphicsRect. Simon also recommended "Render*".
Comment 1 Simon Fraser (smfr) 2011-07-12 17:41:52 PDT 
Graphics* works better for me.
Comment 2 Levi Weintraub 2011-07-12 19:57:44 PDT 
(In reply to comment #1)
> Graphics* works better for me.

Agreed. Graphics it is -- it's more descriptive of the actual use.
Comment 3 Levi Weintraub 2011-07-13 16:57:08 PDT 
Created attachment 100730 [details]
Rev 1, Mac only

Only changed the Mac platform so this patch isn't done, but it is absolutely massive... Simon, mind doing a sanity check?
Comment 4 Levi Weintraub 2011-07-13 17:06:28 PDT 
Created attachment 100734 [details]
Trying Again

Forgot to add the new files.
Comment 5 Levi Weintraub 2011-07-14 14:21:14 PDT 
Created attachment 100862 [details]
Patch
Comment 6 Levi Weintraub 2011-07-14 14:42:20 PDT 
Created attachment 100866 [details]
Patch
Comment 7 Levi Weintraub 2011-07-14 14:42:52 PDT 
Trying to get a patch to apply...
Comment 8 Levi Weintraub 2011-07-14 16:37:56 PDT 
Created attachment 100894 [details]
Patch
Comment 9 Levi Weintraub 2011-07-14 16:39:28 PDT 
One more try before changing tact.
Comment 10 Levi Weintraub 2011-07-15 10:55:38 PDT 
Changing tact and landing in pieces with a typedef. This is just way too damn big. Sorry about the noise.