Bug 64413

Summary: Rename FloatRect/Point/Size and move them to an abstraction
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, eae, eric, hyatt, mitz, mjs, peter, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64754    
Bug Blocks: 63567, 64405    
Attachments:
Description Flags
Rev 1, Mac only
none
Trying Again
none
Patch
none
Patch
none
Patch none

Levi Weintraub
Reported 2011-07-12 17:31:34 PDT
We may want to use something other than floats for the various graphics structures on different platforms -- namely CGFloat on Mac -- so renaming the floating point graphics structures to something more generic. I recommend "Graphics*": GraphicsUnit, GraphicsPoint, GraphicsSize, and GraphicsRect. Simon also recommended "Render*".
Attachments
Rev 1, Mac only (917.31 KB, patch)
2011-07-13 16:57 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Trying Again (969.98 KB, patch)
2011-07-13 17:06 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (1.80 MB, patch)
2011-07-14 14:21 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (1.80 MB, patch)
2011-07-14 14:42 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (1.81 MB, patch)
2011-07-14 16:37 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-07-12 17:41:52 PDT
Graphics* works better for me.
Levi Weintraub
Comment 2 2011-07-12 19:57:44 PDT
(In reply to comment #1) > Graphics* works better for me. Agreed. Graphics it is -- it's more descriptive of the actual use.
Levi Weintraub
Comment 3 2011-07-13 16:57:08 PDT
Created attachment 100730 [details] Rev 1, Mac only Only changed the Mac platform so this patch isn't done, but it is absolutely massive... Simon, mind doing a sanity check?
Levi Weintraub
Comment 4 2011-07-13 17:06:28 PDT
Created attachment 100734 [details] Trying Again Forgot to add the new files.
Levi Weintraub
Comment 5 2011-07-14 14:21:14 PDT
Created attachment 100862 [details] Patch
Levi Weintraub
Comment 6 2011-07-14 14:42:20 PDT
Created attachment 100866 [details] Patch
Levi Weintraub
Comment 7 2011-07-14 14:42:52 PDT
Trying to get a patch to apply...
Levi Weintraub
Comment 8 2011-07-14 16:37:56 PDT
Created attachment 100894 [details] Patch
Levi Weintraub
Comment 9 2011-07-14 16:39:28 PDT
One more try before changing tact.
Levi Weintraub
Comment 10 2011-07-15 10:55:38 PDT
Changing tact and landing in pieces with a typedef. This is just way too damn big. Sorry about the noise.
Note You need to log in before you can comment on or make changes to this bug.