Summary: | REGRESSION (r90699): 12 svg tests failing on Windows XP Debug (Tests) and 13 tests failing on Windows 7 Release (WebKit2 Tests) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, eric, evan, tony |
Priority: | P2 | Keywords: | LayoutTestFailure, MakingBotsRed, Regression |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Windows XP | ||
URL: | http://build.webkit.org/results/Windows XP Debug (Tests)/r90699 (30528)/results.html |
Description
Adam Roben (:aroben)
2011-07-11 06:44:25 PDT
Looks like the win-xp results for these tests were removed in r90699. I wonder what it was that made Adam think they were "redundant"? Well, I'll just put them back I guess. *** Bug 64278 has been marked as a duplicate of this bug. *** This also caused 13 tests to fail on WebKit2: editing/selection/caret-ltr-right.html editing/selection/drag-text-delay.html fast/css/pseudo-any.html fast/forms/textfield-overflow.html fast/ruby/after-block-doesnt-crash.html fast/ruby/after-table-doesnt-crash.html fast/ruby/before-block-doesnt-crash.html fast/ruby/before-table-doesnt-crash.html fast/ruby/generated-after-counter-doesnt-crash.html fast/ruby/generated-before-and-after-counter-doesnt-crash.html fast/ruby/generated-before-counter-doesnt-crash.html plugins/resize-from-plugin.html plugins/npruntime/embed-property-equality.html Committed r90744: <http://trac.webkit.org/changeset/90744> The deduplicate result script said they were. We should figure out why the script was wrong. Apparently the script did some wrong things for WebKit2 as well. Sounds like the script needs some more work to be reliable. (In reply to comment #7) > Apparently the script did some wrong things for WebKit2 as well. Sounds like the script needs some more work to be reliable. Are the win-xp and the webkit2 bots using NRWT? It gets the result fallback order from port.py. (In reply to comment #8) > (In reply to comment #7) > > Apparently the script did some wrong things for WebKit2 as well. Sounds like the script needs some more work to be reliable. > > Are the win-xp and the webkit2 bots using NRWT? No. The wk2 fallback paths are supposed to be correct for NRWT. Maybe there's some problem with how Eric added them? Sorry. Yes, the WK2 fallback paths are supposed to be correct, but I'm not surprised if they're not since https://bugs.webkit.org/show_bug.cgi?id=56729 is not solved yet. NRWT also doesn't work for win https://bugs.webkit.org/show_bug.cgi?id=38756, so I'm not surprised the fallback paths were wrong there too. We should fix deduplicate tests to not operate on ports that we know NRWT doesn't support yet. :( (We should also fix the fallback paths on those port objects in NRWT, but if we're not using them, they're likely to go wrong again.) |