Summary: | Generate conditional include statements in CodeGeneratorJS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | Tools / Tests | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 64960, 64961, 65040 | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2011-07-09 10:45:48 PDT
Created attachment 100210 [details]
Patch
Comment on attachment 100210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review Great idea! I have a question (inline), but otherwise looks good. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948 > + foreach my $include (sort keys %implIncludes) { We didn't sort these keys previously. Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output? Comment on attachment 100210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948 >> + foreach my $include (sort keys %implIncludes) { > > We didn't sort these keys previously. Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output? Uhh, it's a relict of a temporary change. I'll remove it. Committed r90717: <http://trac.webkit.org/changeset/90717> |