Bug 64077

Summary: DFG JIT does not implement get_by_id prototype caching
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-07-07 02:31:16 PDT
The JSC JIT emits stubs to cache get_by_id prototype accesses. The DFG JIT does not implement this optimization.
Attachments
the patch (8.59 KB, patch)
2011-07-07 02:50 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-07-07 02:50:35 PDT
Created attachment 99963 [details] the patch
Gavin Barraclough
Comment 2 2011-07-07 16:17:14 PDT
Comment on attachment 99963 [details] the patch I think there might be an alternative given the way we're currently code generating the self accesses. We may be able to plant a couple of extra instructions inline in the JIT code to load to prototype & check its structure, immediately prior to the load. But this is just a possible idea to explore - patch as is looks fine.
WebKit Review Bot
Comment 3 2011-07-07 16:48:52 PDT
Comment on attachment 99963 [details] the patch Clearing flags on attachment: 99963 Committed r90601: <http://trac.webkit.org/changeset/90601>
WebKit Review Bot
Comment 4 2011-07-07 16:48:56 PDT
All reviewed patches have been landed. Closing bug.
Gavin Barraclough
Comment 5 2011-07-08 16:43:40 PDT
Reopening - these changes were rolled out in r90673 due to https://bugs.webkit.org/show_bug.cgi?id=64181
Gavin Barraclough
Comment 6 2011-07-17 01:05:27 PDT
Closing, I think these changes were landed as a part of another bug. Filip, please reopen if I'm mistaken & this is still a live issue.
Note You need to log in before you can comment on or make changes to this bug.