Summary: | SVGAnimateTransform accumulate=sum restarts on every repeat | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, bulach, dglazkov, webkit.review.bot, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | http://dev.w3.org/SVG/profiles/1.1F2/test/svg/animate-elem-81-t.svg | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 41761 | ||||||||||
Attachments: |
|
Description
Dirk Schulze
2011-07-03 11:25:59 PDT
Created attachment 99576 [details]
Patch
Comment on attachment 99576 [details] Patch Attachment 99576 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8977709 New failing tests: svg/animations/svgtransform-animation-1.html Created attachment 99577 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 99579 [details]
Patch
Comment on attachment 99576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99576&action=review > Source/WebCore/ChangeLog:7 > + > + SVGAnimateTransform accumulate=sum restarts on every repeat > + https://bugs.webkit.org/show_bug.cgi?id=63876 > + > + Reviewed by NOBODY (OOPS!). > + Order is wrong. > Source/WebCore/ChangeLog:13 > + > + Test: svg/animations/svgtransform-animation-1.html So what is fixed now? Again in one sentence pls. Fix accumulate="sum" on <animateTransform> > LayoutTests/svg/animations/svgtransform-animation-1-expected.txt:15 > +FAIL rect.transform.animVal.getItem(0).type should be 3. Was 13. > +FAIL rect.transform.animVal.getItem(0).matrix.a should be close to 1. Was 0. > +FAIL rect.transform.animVal.getItem(0).matrix.d should be close to 1. Was 0. Fails? Comment on attachment 99579 [details]
Patch
Ah, r=me, sorry didn't see the new patch before.
Comment on attachment 99579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99579&action=review Ah, r=me, sorry didn't see the new patch before. But please fixup the ChangeLogs. (Or were there a recent change to the style? I remember discussions...) > Source/WebCore/ChangeLog:6 > + SVGAnimateTransform accumulate=sum restarts on every repeat > + https://bugs.webkit.org/show_bug.cgi?id=63876 > + > + Reviewed by NOBODY (OOPS!). Order is wrong. > Order is wrong.
Apparently this order change is intentional. There was a thread on webkit-dev about it.
Committed r90345: <http://trac.webkit.org/changeset/90345> Hello, This new test is failing on some of the chromium bots. Logs and more details at: https://bugs.webkit.org/show_bug.cgi?id=63902 I disabled it temporarily on the failing platforms (apparently it's ok on linux but fails on mac / win). Would you mind taking a quick look at it, please? Any help would be greatly appreciated! |