| Summary: | [WebKit2] Consider scale factor when allocating backing store | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||
| Component: | WebKit2 | Assignee: | Darin Adler <darin> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | andersca, dbates, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Darin Adler
2011-06-30 16:01:55 PDT
Created attachment 99392 [details]
Patch
Created attachment 99393 [details]
Patch
Comment on attachment 99393 [details]
Patch
I don't think we should complicate ShareableBitmap by introducing the notion of a scale factor into the design. The ShareableBitmap is intended to be pixel-based and not know anything about scale factors.
(In reply to comment #3) > I don't think we should complicate ShareableBitmap by introducing the notion of a scale factor into the design. The ShareableBitmap is intended to be pixel-based and not know anything about scale factors. I did that because ShareableBitmap is both the class that is making the graphics context for drawing into the bitmap and the class that is doing the painting from the bitmap. If I try to do this at another level, I expect I’ll have to modify multiple classes. But I’ll give it a shot. Created attachment 99408 [details]
Patch
This patch handles less then the previous version. It does not take the backing scale factor into account when dealing with the find indicator. It was easier to share code for that when it was handled at the bitmap level. But I can do the find indicator separately. Created attachment 99412 [details]
Patch
This new one is just the previous patch rebased. I assume that was needed to make it apply on Qt, for example. Given what EWS now says, I guess I was wrong. Comment on attachment 99412 [details] Patch Clearing flags on attachment: 99412 Committed r90198: <http://trac.webkit.org/changeset/90198> All reviewed patches have been landed. Closing bug. For completeness, the scale factor overloaded ShareableBitmap::paint() will need to be implemented for Qt, GTK, and Cairo. Filed bugs: Qt: <https://bugs.webkit.org/show_bug.cgi?id=64663> GTK: <https://bugs.webkit.org/show_bug.cgi?id=64664> Cairo: <https://bugs.webkit.org/show_bug.cgi?id=64665> |