| Summary: | new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, ossy, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 34984 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2011-06-28 11:28:55 PDT
Created attachment 98950 [details]
Patch
Just slowly burning down the list of failures on http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28NRWT%29 Comment on attachment 98950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) Nit: Should we sort these alphabetically? Comment on attachment 98950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review Thanks for the review! >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > Nit: Should we sort these alphabetically? I'm not sure it really matters given that they're a set. :) (In reply to comment #4) > (From update of attachment 98950 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > > Thanks for the review! > > >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > > > Nit: Should we sort these alphabetically? > > I'm not sure it really matters given that they're a set. :) The sorting is to make it easier for humans to read, not the computer :) Comment on attachment 98950 [details] Patch Clearing flags on attachment: 98950 Committed r89949: <http://trac.webkit.org/changeset/89949> All reviewed patches have been landed. Closing bug. |