Bug 63346

Summary:

Change NDEBUG to !LOG_DISABLED macro in databases for logging.

Product:

WebKit

Reporter:

Lukasz Slachciak <l.slachciak>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64590

Attachments:

Description	Flags
Logging in databases patch	none

Description Lukasz Slachciak 2011-06-24 13:27:34 PDT

Changed NDEBUG to !LOG_DISABLED in databases code which involves logging. This change resolves also build break in Release build when logging enabled.

Comment 1 Lukasz Slachciak 2011-06-24 13:32:12 PDT

Created attachment 98528 [details]
Logging in databases patch

Comment 2 WebKit Review Bot 2011-06-24 15:04:42 PDT

The commit-queue encountered the following flaky tests while processing attachment 98528 [details]:

http/tests/local/formdata/upload-events.html bug 63357 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.

Comment 3 WebKit Review Bot 2011-06-24 15:07:22 PDT

Comment on attachment 98528 [details]
Logging in databases patch

Clearing flags on attachment: 98528

Committed r89708: <http://trac.webkit.org/changeset/89708>

Comment 4 WebKit Review Bot 2011-06-24 15:07:26 PDT

All reviewed patches have been landed.  Closing bug.