Summary: | [GTK] Install a custom X error handler in plugin process | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 60546 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-06-23 05:22:45 PDT
Created attachment 98336 [details] Patch Fixes a crash in plugin process when loading http://www.f1.com Comment on attachment 98336 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41 > + gchar errorMessage[64]; > + XGetErrorText(xdisplay, error->error_code, errorMessage, 63); Is 64 enough here? (In reply to comment #2) > (From update of attachment 98336 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review > > > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41 > > + gchar errorMessage[64]; > > + XGetErrorText(xdisplay, error->error_code, errorMessage, 63); > > Is 64 enough here? it's based on GDK code, see: http://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkdisplay-x11.c#n2351 so I guess it's enough, we could use something like 1024 to make sure. Committed r91062: <http://trac.webkit.org/changeset/91062> |