Bug 63117

Summary: IndexedDB createObjectStore should NOT throw if name is null
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, hans, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02 none

Mark Pilgrim (Google)
Reported 2011-06-21 21:01:35 PDT
Calling db.createObjectStore(null) should behave identically to calling db.createObjectStore("null"). I have double-checked this (highly unintuitive) behavior with the author of the WebIDL spec and he confirms it ( http://krijnhoetmer.nl/irc-logs/whatwg/20110622#l-187 ). There was also apparently a WebIDL spec bug recently asking to change this behavior, but it was WONTFIXED ( http://www.w3.org/Bugs/Public/show_bug.cgi?id=12798 ). End result: null values for DOMString arguments get stringified to the four-character string "null". This affects several functions in WebKit's IndexedDB implementation. I am filing separate bugs for each of them. (See bug 63110 and bug 63114, for instance.) Patch attached.
Attachments
Patch (3.39 KB, patch)
2011-06-21 21:08 PDT, Mark Pilgrim (Google) 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-02 (1.44 MB, application/zip)
2011-06-21 23:22 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-06-21 21:08:14 PDT
Created attachment 98113 [details] Patch
WebKit Review Bot
Comment 2 2011-06-21 23:22:11 PDT
Comment on attachment 98113 [details] Patch Attachment 98113 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8920225
WebKit Review Bot
Comment 3 2011-06-21 23:22:16 PDT
Created attachment 98122 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Mark Pilgrim (Google)
Comment 4 2011-06-22 08:13:58 PDT
Consolidating several bugs. *** This bug has been marked as a duplicate of bug 63140 ***
Hajime Morrita
Comment 5 2011-06-27 02:13:05 PDT
Comment on attachment 98113 [details] Patch Marking obsolete as the bug closed.
Note You need to log in before you can comment on or make changes to this bug.