Bug 63110 - IndexedDB open (database) should NOT throw if name is null
Summary: IndexedDB open (database) should NOT throw if name is null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 18:56 PDT by Mark Pilgrim (Google)
Modified: 2011-06-22 17:57 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.42 KB, patch)
2011-06-21 19:01 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-06-21 18:56:51 PDT
Bug 60022 was wrong, and Mozilla's implementation was wrong. Calling indexedDB.open(null) should behave identically to calling indexedDB.open("null"). I have double-checked this (highly unintuitive) behavior with the author of the WebIDL spec and he confirms it ( http://krijnhoetmer.nl/irc-logs/whatwg/20110622#l-187 ). There was also apparently a WebIDL spec bug recently asking to change this behavior, but it was WONTFIXED ( http://www.w3.org/Bugs/Public/show_bug.cgi?id=12798 ).

End result: null values for DOMString arguments get stringified to the four-character string "null". This affects several functions in WebKit's IndexedDB implementation. I will file separate bugs for each of them.

Patch attached.
Comment 1 Mark Pilgrim (Google) 2011-06-21 19:01:29 PDT
Created attachment 98099 [details]
Patch
Comment 2 David Grogan 2011-06-21 19:17:42 PDT
Comment on attachment 98099 [details]
Patch

LGTM but could you add abarth to the reviewers since he seems to really know this stuff.  Unless Tony also feels confident about it.
Comment 3 WebKit Review Bot 2011-06-22 17:57:54 PDT
Comment on attachment 98099 [details]
Patch

Clearing flags on attachment: 98099

Committed r89506: <http://trac.webkit.org/changeset/89506>
Comment 4 WebKit Review Bot 2011-06-22 17:57:59 PDT
All reviewed patches have been landed.  Closing bug.