Bug 63003

Summary: REGRESSION (r79060): Searching for a flight at united.com fails
Product: WebKit Reporter: Adele Peterson <adele>
Component: JavaScriptCoreAssignee: Adele Peterson <adele>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, oliver
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
Patch darin: review+

Adele Peterson
Reported 2011-06-20 11:32:18 PDT
REGRESSION (r79060): Searching for a flight at united.com fails
Attachments
patch (4.33 KB, patch)
2011-06-20 11:40 PDT, Adele Peterson 		no flags
DetailsFormatted DiffDiff
patch (4.55 KB, patch)
2011-06-20 11:54 PDT, Adele Peterson 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2011-06-20 12:44 PDT, Oliver Hunt 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2011-06-20 11:36:06 PDT
Steps to reproduce: 1. Go to ual.com 2. Click on the 'Redeem Miles' tab 3. Click on 'One-way' 4. Click in the departure field which will pop up a calendar, choose a date (e.g. 8/20/2011 is what I was using) 5. Enter departure and arrival cities (like SFO and EWR) 6. Click Search
Adele Peterson
Comment 2 2011-06-20 11:40:49 PDT
Created attachment 97829 [details] patch
Adele Peterson
Comment 3 2011-06-20 11:53:59 PDT
The original patch also broke Twitter, and we tried to refine the original change to fix that in this bug: https://bugs.webkit.org/show_bug.cgi?id=55228 http://trac.webkit.org/changeset/80542 My patch reverts the original change, and we can figure out how to refix this without breaking Twitter and United later.
Adele Peterson
Comment 4 2011-06-20 11:54:25 PDT
Created attachment 97831 [details] patch
Oliver Hunt
Comment 5 2011-06-20 12:03:34 PDT
Comment on attachment 97831 [details] patch Is there a testcase for the date that broke? rolling out this patch without adding a test for the breakage is going to make it hard to fix parsing properly without potentially reintroducing this bug again.
Oliver Hunt
Comment 6 2011-06-20 12:13:18 PDT
Quick check implies that we need a test for new Date("Mon Jun 20 11:01:36 CDT 2011")
Oliver Hunt
Comment 7 2011-06-20 12:44:50 PDT
Created attachment 97841 [details] Patch
Oliver Hunt
Comment 8 2011-06-20 12:46:43 PDT
Committed r89281: <http://trac.webkit.org/changeset/89281>
Darin Adler
Comment 9 2011-06-20 12:47:02 PDT
<rdar://problem/9637155>
Note You need to log in before you can comment on or make changes to this bug.