Summary: | REGRESSION (r79060): Searching for a flight at united.com fails | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adele Peterson <adele> | ||||||||
Component: | JavaScriptCore | Assignee: | Adele Peterson <adele> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, oliver | ||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adele Peterson
2011-06-20 11:32:18 PDT
Steps to reproduce: 1. Go to ual.com 2. Click on the 'Redeem Miles' tab 3. Click on 'One-way' 4. Click in the departure field which will pop up a calendar, choose a date (e.g. 8/20/2011 is what I was using) 5. Enter departure and arrival cities (like SFO and EWR) 6. Click Search Created attachment 97829 [details]
patch
The original patch also broke Twitter, and we tried to refine the original change to fix that in this bug: https://bugs.webkit.org/show_bug.cgi?id=55228 http://trac.webkit.org/changeset/80542 My patch reverts the original change, and we can figure out how to refix this without breaking Twitter and United later. Created attachment 97831 [details]
patch
Comment on attachment 97831 [details]
patch
Is there a testcase for the date that broke? rolling out this patch without adding a test for the breakage is going to make it hard to fix parsing properly without potentially reintroducing this bug again.
Quick check implies that we need a test for new Date("Mon Jun 20 11:01:36 CDT 2011") Created attachment 97841 [details]
Patch
Committed r89281: <http://trac.webkit.org/changeset/89281> |