Bug 62959

Summary: [EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, kenneth, krit, leandro, lucas.de.marchi, mrobinson, rakuco, ryuan.choi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62709    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Hyowon Kim 2011-06-19 19:21:17 PDT 
This patch adds some PLATFORM(EFL) ifdefs to GraphicsContext3D.cpp.
Comment 1 Hyowon Kim 2011-06-19 19:53:32 PDT 
Created attachment 97733 [details]
Patch
Comment 2 Gyuyoung Kim 2011-06-19 21:22:40 PDT 
Comment on attachment 97733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review

> Source/WebCore/ChangeLog:8
> +        No new functionality, no new tests.

If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description.
Comment 3 Hyowon Kim 2011-06-20 02:18:01 PDT 
Created attachment 97767 [details]
Patch
Comment 4 Hyowon Kim 2011-06-20 02:25:25 PDT 
(In reply to comment #2)
> (From update of attachment 97733 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new functionality, no new tests.
> 
> If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description.

Thanks Gyuyoung. I've deleted the line.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-06-20 07:05:32 PDT 
The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there?
Comment 6 Hyowon Kim 2011-06-20 20:02:38 PDT 
(In reply to comment #5)
> The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there?

You're right~ I agree. I will modify the dependency. Thanks
Comment 7 Ryuan Choi 2011-06-27 00:30:33 PDT 
Informal r+ on my side.

Could anyone review this?
Comment 8 Gyuyoung Kim 2011-06-27 00:39:02 PDT 
CC'ing Martin and Dirk. 

Martin and Dirk, Could you please review this patch?
Comment 9 WebKit Review Bot 2011-06-27 09:57:22 PDT 
Comment on attachment 97767 [details]
Patch

Clearing flags on attachment: 97767

Committed r89827: <http://trac.webkit.org/changeset/89827>
Comment 10 WebKit Review Bot 2011-06-27 09:57:28 PDT 
All reviewed patches have been landed.  Closing bug.