| Summary: | Drop MutableTextTrack and make TextTrack always mutable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anna Cavender <annacc> | ||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, gustavo.noronha, gustavo, ojan, philipj, webkit-bug-importer, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 43668 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Anna Cavender
2011-06-17 11:05:24 PDT
MutableTextTrack was recently removed from the whatwg spec: http://html5.org/tools/web-apps-tracker?from=6709&to=6710 Created attachment 111853 [details]
Proposed patch
Pull MutableTextTrack functionality into TextTrack.
Comment on attachment 111853 [details] Proposed patch Attachment 111853 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10177708 Created attachment 111973 [details]
Updated patch
Remove MutableTextTrack and its friends from a few more build files.
Comment on attachment 111973 [details] Updated patch Attachment 111973 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10181909 Comment on attachment 111973 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=111973&action=review This change is testable, since there shouldn't be a window.MutableTextTrack property anymore. Was there no test for that before? Is it not exposed on DOMWindow.idl at all yet? > Source/WebCore/html/HTMLMediaElement.cpp:1986 > + RefPtr<TextTrack> track = TextTrack::create(this, kind, label, language); > + return track.release(); This RefPtr is not necessary. (In reply to comment #7) > (From update of attachment 111973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111973&action=review > > This change is testable, since there shouldn't be a window.MutableTextTrack property anymore. Was there no test for that before? Is it not exposed on DOMWindow.idl at all yet? > No, not all of the cue classes are in DOMWindow.idl yet. I will file a bug about this. > > Source/WebCore/html/HTMLMediaElement.cpp:1986 > > + RefPtr<TextTrack> track = TextTrack::create(this, kind, label, language); > > + return track.release(); > > This RefPtr is not necessary. Indeed, thanks! Created attachment 112028 [details]
Updated patch
|