Bug 62807

Summary:

SVGAnimation should use direct unit animation for SVGAngle

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Dirk Schulze <krit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

41761

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	rwlbuis: review+, webkit.review.bot: commit-queue-

Dirk Schulze

Reported 2011-06-16 12:03:27 PDT

SVGAnimation should use direct unit animation for SVGAngle as analogue to SVGLength animation.

Attachments
Patch (56.62 KB, patch) 2011-06-16 13:17 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Patch (56.82 KB, patch) 2011-06-16 14:08 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Patch (63.00 KB, patch) 2011-06-17 13:24 PDT, Dirk Schulze	rwlbuis: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2011-06-16 13:17:38 PDT

Created attachment 97481 [details] Patch

Rob Buis

Comment 2 2011-06-16 13:33:25 PDT

Comment on attachment 97481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97481&action=review r- for now since it will fail to compile on a lot of platforms right now. > Source/WebCore/ChangeLog:9 > + This patch continues the convertion to the new concept of SVGAnimatorFactory with SVGAngle. We can animte the SVG primitive datatype SVGAngle conversion && animate > Source/WebCore/ChangeLog:22 > + * WebCore.xcodeproj/project.pbxproj: You are missing at least vcproj and .pro files! > Source/WebCore/CMakeLists.txt:1652 > + svg/SVGAnimatedAnlge.cpp typo!

Dirk Schulze

Comment 3 2011-06-16 14:08:12 PDT

Created attachment 97492 [details] Patch

Collabora GTK+ EWS bot

Comment 4 2011-06-16 14:29:30 PDT

Comment on attachment 97492 [details] Patch Attachment 97492 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8878300

Early Warning System Bot

Comment 5 2011-06-16 14:30:21 PDT

Comment on attachment 97492 [details] Patch Attachment 97492 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8877333

Rob Buis

Comment 6 2011-06-16 14:30:31 PDT

Comment on attachment 97492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97492&action=review Looks good in general, the description needs to be fixed though and I posted a question. > Source/WebCore/svg/SVGAnimateElement.cpp:555 > + || m_animatedAttributeType == AnimatedLength) Could be on one line. > LayoutTests/svg/animations/script-tests/svgangle-animation-deg-to-grad.js:1 > +description("Test SVGLength animation from px to cm."); Please fix all descriptions. > LayoutTests/svg/animations/script-tests/svgangle-animation-rad-to-grad.js:22 > +marker.appendChild(polyline); Is it possible to put the above setup work into the html? Would make the js files smaller.

Dirk Schulze

Comment 7 2011-06-16 14:38:13 PDT

Did not add the file SVGAnimatedAngle.cpp. Shouldn't upload patches that late. :-)

Dirk Schulze

Comment 8 2011-06-17 13:24:28 PDT

Created attachment 97646 [details] Patch

Rob Buis

Comment 9 2011-06-17 13:30:54 PDT

Comment on attachment 97646 [details] Patch Looks good, but make sure to update the ChangeLog for WebCore.pro change.

WebKit Review Bot

Comment 10 2011-06-17 13:43:40 PDT

Comment on attachment 97646 [details] Patch Attachment 97646 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8877713