Bug 62779

Summary: [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, mihaip, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62789    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Sailesh Agrawal
Reported 2011-06-15 22:47:09 PDT
[Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
Attachments
Patch (25.17 KB, patch)
2011-06-15 22:48 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (25.14 KB, patch)
2011-06-16 11:42 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1 2011-06-15 22:48:04 PDT
Created attachment 97404 [details] Patch
James Robinson
Comment 2 2011-06-15 23:09:13 PDT
Comment on attachment 97404 [details] Patch OK. What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently?
Sailesh Agrawal
Comment 3 2011-06-15 23:12:43 PDT
(In reply to comment #2) > (From update of attachment 97404 [details]) > OK. What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently? Do you mean after this patch? It's not much: - change compile time #if USE(WK_SCROLLBAR_PAINTER) to runtime if (isScrollbarOverlayAPIAvailable()) - early out in ScrollAnimatorChromiumMac::scroll if smooth scrolling is disabled - rename ScrollbarThemeMac to ScrollbarThemeChromiumMac
WebKit Review Bot
Comment 5 2011-06-16 00:12:06 PDT
Comment on attachment 97404 [details] Patch Clearing flags on attachment: 97404 Committed r89011: <http://trac.webkit.org/changeset/89011>
WebKit Review Bot
Comment 6 2011-06-16 00:12:11 PDT
All reviewed patches have been landed. Closing bug.
Sailesh Agrawal
Comment 7 2011-06-16 11:41:14 PDT
Re-opening since the original change got backed out.
Sailesh Agrawal
Comment 8 2011-06-16 11:42:30 PDT
Created attachment 97473 [details] Patch
Sailesh Agrawal
Comment 9 2011-06-16 11:45:03 PDT
Merged latest changes from this revision: https://trac.webkit.org/changeset/88982 Please take another look.
Mihai Parparita
Comment 10 2011-06-16 13:28:09 PDT
Comment on attachment 97473 [details] Patch Rubber-stamping since James is out.
WebKit Review Bot
Comment 11 2011-06-16 14:21:04 PDT
Comment on attachment 97473 [details] Patch Clearing flags on attachment: 97473 Committed r89066: <http://trac.webkit.org/changeset/89066>
WebKit Review Bot
Comment 12 2011-06-16 14:21:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.