| Summary: | [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sailesh Agrawal <sail> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, jamesr, mihaip, thakis, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 62789 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Sailesh Agrawal
2011-06-15 22:47:09 PDT
Created attachment 97404 [details]
Patch
Comment on attachment 97404 [details]
Patch
OK. What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently?
(In reply to comment #2) > (From update of attachment 97404 [details]) > OK. What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently? Do you mean after this patch? It's not much: - change compile time #if USE(WK_SCROLLBAR_PAINTER) to runtime if (isScrollbarOverlayAPIAvailable()) - early out in ScrollAnimatorChromiumMac::scroll if smooth scrolling is disabled - rename ScrollbarThemeMac to ScrollbarThemeChromiumMac Layout try bots look good: http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/208 http://build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/builds/273 (windows one is still pending). Comment on attachment 97404 [details] Patch Clearing flags on attachment: 97404 Committed r89011: <http://trac.webkit.org/changeset/89011> All reviewed patches have been landed. Closing bug. Re-opening since the original change got backed out. Created attachment 97473 [details]
Patch
Merged latest changes from this revision: https://trac.webkit.org/changeset/88982 Please take another look. Comment on attachment 97473 [details]
Patch
Rubber-stamping since James is out.
Comment on attachment 97473 [details] Patch Clearing flags on attachment: 97473 Committed r89066: <http://trac.webkit.org/changeset/89066> All reviewed patches have been landed. Closing bug. |