[EFL][WK2] Add missing functions of EFL port's PageClientImpl

• Component: WebKit2
• Status: RESOLVED FIXED

[Eunmi Lee]

I've added missing functions of EFL port's PageClientImpl.cpp.
There are 3 functions which is added in the latest PageClient.h.
+IntPoint PageClientImpl::screenToWindow(const IntPoint&)
+void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext&)
+void PageClientImpl::exitAcceleratedCompositingMode()

[Eunmi Lee]

Created attachment 97266 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 97266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170
> +IntPoint PageClientImpl::screenToWindow(const IntPoint&)
> +{
> +    notImplemented();
> +    return IntPoint();
> +}

Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0

[Eunmi Lee]

Created attachment 97391 [details]
Patch

[Eunmi Lee]

(In reply to comment #2)
> (From update of attachment 97266 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170
> > +IntPoint PageClientImpl::screenToWindow(const IntPoint&)
> > +{
> > +    notImplemented();
> > +    return IntPoint();
> > +}
> 
> Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0

OK, I've changed to return the given point :)

[Gyuyoung Kim]

LGTM.

[Leandro Pereira]

(In reply to comment #4)
> 
> OK, I've changed to return the given point :)
>

Looks like you've sent the old patch again :)

[Eunmi Lee]

(In reply to comment #6)
> (In reply to comment #4)
> > 
> > OK, I've changed to return the given point :)
> >
> 
> Looks like you've sent the old patch again :)

Oh, I changed as follows :)
-169 return IntPoint()
+169 return point;

[Leandro Pereira]

(In reply to comment #7)
> > 
> > Looks like you've sent the old patch again :)
> 
> Oh, I changed as follows :)
> -169 return IntPoint()
> +169 return point;

Oops, missed that :)

[WebKit Review Bot]

Comment on attachment 97391 [details]
Patch

Clearing flags on attachment: 97391

Committed r89210: <http://trac.webkit.org/changeset/89210>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.