Bug 62523

Summary: [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, ryuan.choi, sangseok.lim, tonikitoo, webkit.review.bot, youngtaeck.song
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch none

Eunmi Lee
Reported 2011-06-12 19:55:29 PDT
This class's functions are not implemented yet, but it is needed to prevent build error.
Attachments
Patch (3.38 KB, patch)
2011-06-12 19:58 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2011-06-12 19:58:20 PDT
Created attachment 96910 [details] Patch
Gyuyoung Kim
Comment 2 2011-06-12 22:32:08 PDT
LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-06-13 06:14:32 PDT
Looks OK after correcting the following nitpicks. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52 > + return ""; I'd rather return a String() directly here. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:58 > + return ""; Ditto. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:64 > + return ""; Ditto.
Eric Seidel (no email)
Comment 4 2011-06-13 14:43:51 PDT
Comment on attachment 96910 [details] Patch OK.
WebKit Review Bot
Comment 5 2011-06-13 14:51:55 PDT
Comment on attachment 96910 [details] Patch Clearing flags on attachment: 96910 Committed r88701: <http://trac.webkit.org/changeset/88701>
WebKit Review Bot
Comment 6 2011-06-13 14:52:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.