Summary: | [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eunmi Lee <enmi.lee> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | antognolli+webkit, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, ryuan.choi, sangseok.lim, tonikitoo, webkit.review.bot, youngtaeck.song | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 61838 | ||||||
Attachments: |
|
Description
Eunmi Lee
2011-06-12 19:55:29 PDT
Created attachment 96910 [details]
Patch
LGTM. Looks OK after correcting the following nitpicks. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52 > + return ""; I'd rather return a String() directly here. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:58 > + return ""; Ditto. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:64 > + return ""; Ditto. Comment on attachment 96910 [details]
Patch
OK.
Comment on attachment 96910 [details] Patch Clearing flags on attachment: 96910 Committed r88701: <http://trac.webkit.org/changeset/88701> All reviewed patches have been landed. Closing bug. |