Bug 62523

Summary: [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, ryuan.choi, sangseok.lim, tonikitoo, webkit.review.bot, youngtaeck.song
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch none

Description Eunmi Lee 2011-06-12 19:55:29 PDT
This class's functions are not implemented yet, but it is needed to prevent build error.
Comment 1 Eunmi Lee 2011-06-12 19:58:20 PDT
Created attachment 96910 [details]
Patch
Comment 2 Gyuyoung Kim 2011-06-12 22:32:08 PDT
LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-06-13 06:14:32 PDT
Looks OK after correcting the following nitpicks.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52
> +    return "";

I'd rather return a String() directly here.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:58
> +    return "";

Ditto.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:64
> +    return "";

Ditto.
Comment 4 Eric Seidel (no email) 2011-06-13 14:43:51 PDT
Comment on attachment 96910 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2011-06-13 14:51:55 PDT
Comment on attachment 96910 [details]
Patch

Clearing flags on attachment: 96910

Committed r88701: <http://trac.webkit.org/changeset/88701>
Comment 6 WebKit Review Bot 2011-06-13 14:52:00 PDT
All reviewed patches have been landed.  Closing bug.