Bug 62438

Summary: [EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, kenneth, leandro, ryuan.choi, sangseok.lim, tonikitoo, webkit.review.bot, youngtaeck.song
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Eunmi Lee
Reported 2011-06-10 01:00:48 PDT
I added initial classes for webkit2 efl port as follows: WebContextEfl.cpp WebPreferencesEfl.cpp TextCheckerEfl.cpp WebInspectorEfl.cpp
Attachments
Patch (13.51 KB, patch)
2011-06-10 01:06 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (4.82 KB, patch)
2011-06-12 19:50 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2011-06-10 01:06:11 PDT
Created attachment 96709 [details] Patch
Leandro Pereira
Comment 2 2011-06-10 09:41:28 PDT
Could you please split the patch into smaller chunks?
Eunmi Lee
Comment 3 2011-06-12 19:50:02 PDT
Created attachment 96909 [details] Patch
Eunmi Lee
Comment 4 2011-06-12 20:08:49 PDT
(In reply to comment #2) > Could you please split the patch into smaller chunks? I've splited this patch as 4 patches as follows: https://bugs.webkit.org/show_bug.cgi?id=62438 https://bugs.webkit.org/show_bug.cgi?id=62523 https://bugs.webkit.org/show_bug.cgi?id=62524 https://bugs.webkit.org/show_bug.cgi?id=62525
Eric Seidel (no email)
Comment 5 2011-06-13 15:02:19 PDT
Comment on attachment 96909 [details] Patch r=me.
WebKit Review Bot
Comment 6 2011-06-13 15:14:59 PDT
Comment on attachment 96909 [details] Patch Clearing flags on attachment: 96909 Committed r88706: <http://trac.webkit.org/changeset/88706>
WebKit Review Bot
Comment 7 2011-06-13 15:15:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.