Summary: | LayoutTests/fast/css/link-disabled-attr.html fails some cases | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | ahmad.saleem792, ap, ddkilzer, haraken, jab_creations, koivisto | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 65140 | ||||||
Attachments: |
|
Description
Julien Chaffraix
2011-06-09 15:13:09 PDT
Likely related to Bug 65140 (which affects a real-world site). It looks like our binding does not use the same case as the spec and FireFox for one binding: Document.idl: // WebKit extensions readonly attribute [ConvertNullStringTo=Null] DOMString preferredStylesheetSet; attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString selectedStylesheetSet; The spec and Mozilla both use preferredStyleSheetSet and selectedStyleSheetSet. That could be why we are failing this test as we are matching the spec in our test. Created attachment 102915 [details]
Patch
FYI: I found that document.selectedStyle"s"heetSet should be document.selectedStyleSheetSet. (spec: http://dev.w3.org/csswg/cssom/#dom-document-selectedStyleSheetSet) I would like to fix it after this patch is landed. (I guess that we should support both.) The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression. In fact, this patch doesn't seem to apply to ToT now. > In fact, this patch doesn't seem to apply to ToT now.
Strike that, my mistake.
(In reply to comment #5) > The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression. Thank you, I would like to rebase this patch and upload it, after the bug 65140 is landed. I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post. (In reply to comment #9) > I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post. Please open a new bug about this issue. Comment on attachment 102915 [details] Patch Bug 65140 has landed some time ago. Clearing the review flag as the patch needs a rebaseline (mentioned in the bug and we ended up reverting most of the stylesheet loading so I don't know if the patch is still needed). Still has some failures, which this patch was trying to tackle: https://searchfox.org/wubkat/rev/273f22582ad8144106018a89f5c85f1d15da0253/LayoutTests/fast/css/link-disabled-attr-expected.txt |