Bug 62407 – LayoutTests/fast/css/link-disabled-attr.html fails some cases

• Component: CSS
• Status: NEW

[Julien Chaffraix]

As part of bug 61400, some existing differences between us and FF + the spec when loading style sheets were exposed. Those are the 2 failures in link-disabled-attr.html.

[David Kilzer (:ddkilzer)]

Likely related to Bug 65140 (which affects a real-world site).

[Julien Chaffraix]

It looks like our binding does not use the same case as the spec and FireFox for one binding:

Document.idl:

// WebKit extensions

readonly attribute [ConvertNullStringTo=Null] DOMString preferredStylesheetSet;
         attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString selectedStylesheetSet;

The spec and Mozilla both use preferredStyleSheetSet and selectedStyleSheetSet. That could be why we are failing this test as we are matching the spec in our test.

[Kentaro Hara]

Created attachment 102915 [details]
Patch

[Kentaro Hara]

FYI: I found that document.selectedStyle"s"heetSet should be document.selectedStyleSheetSet. (spec: http://dev.w3.org/csswg/cssom/#dom-document-selectedStyleSheetSet) I would like to fix it after this patch is landed. (I guess that we should support both.)

[Alexey Proskuryakov]

The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression.

[Alexey Proskuryakov]

In fact, this patch doesn't seem to apply to ToT now.

[Alexey Proskuryakov]

> In fact, this patch doesn't seem to apply to ToT now.

Strike that, my mistake.

[Kentaro Hara]

(In reply to comment #5)
> The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression.

Thank you, I would like to rebase this patch and upload it, after the bug 65140 is landed.

[John A. Bilicki III]

I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post.

[David Kilzer (:ddkilzer)]

(In reply to comment #9)
> I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post.

Please open a new bug about this issue.

[Julien Chaffraix]

Comment on attachment 102915 [details]
Patch

Bug 65140 has landed some time ago. Clearing the review flag as the patch needs a rebaseline (mentioned in the bug and we ended up reverting most of the stylesheet loading so I don't know if the patch is still needed).

[Ahmad Saleem]

Still has some failures, which this patch was trying to tackle:

https://searchfox.org/wubkat/rev/273f22582ad8144106018a89f5c85f1d15da0253/LayoutTests/fast/css/link-disabled-attr-expected.txt