Bug 62379

Summary: WebKit2: Generate correct header conditionals in message receivers.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Tools / TestsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62290    
Attachments:
Description Flags
Proposed patch
kling: review-
Proposed patch v2 none

Andreas Kling
Reported 2011-06-09 08:23:58 PDT
Given a *.messages.in file like this: Bar(WebCore::IntRect rect) #if ENABLE(ESOTERIC_FEATURE) Foo(WebCore::IntRect rect) #endif messages.py would include the WebCore argument coders only #if ENABLE(ESOTERIC_FEATURE). This breaks the build on platforms without that defined. It also breaks for this case: #if ENABLE(FOO) Foo(WebCore::IntRect rect) #endif #if ENABLE(BAR) Bar(WebCore::IntRect rect) #endif Where we would get the include only #if ENABLE(FOO). This should be #if ENABLE(FOO) || ENABLE(BAR) instead.
Attachments
Proposed patch (4.50 KB, patch)
2011-06-09 09:16 PDT, Andreas Kling 		kling: review-
DetailsFormatted DiffDiff
Proposed patch v2 (14.80 KB, patch)
2011-06-09 10:50 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-06-09 09:16:52 PDT
Created attachment 96595 [details] Proposed patch
Andreas Kling
Comment 2 2011-06-09 09:27:35 PDT
Comment on attachment 96595 [details] Proposed patch Self r- due to missing unit test. Didn't notice we have those for messages.py. :)
Andreas Kling
Comment 3 2011-06-09 10:50:43 PDT
Created attachment 96604 [details] Proposed patch v2
Andreas Kling
Comment 4 2011-06-09 11:14:28 PDT
Comment on attachment 96604 [details] Proposed patch v2 Clearing flags on attachment: 96604 Committed r88462: <http://trac.webkit.org/changeset/88462>
Andreas Kling
Comment 5 2011-06-09 11:14:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.