Bug 62290

Summary: [Qt][WK2] Remove usage of deprecated CoreIPC functions.
Product: WebKit Reporter: Andreas Kling <kling>
Component: New BugsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62379    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2011-06-08 09:19:43 PDT
TiledDrawingArea should move away from CoreIPC::deprecatedSend() and CoreIPC::deprecatedWaitFor().
Attachments
Proposed patch (40.97 KB, patch)
2011-06-08 09:55 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-06-08 09:55:57 PDT
Created attachment 96436 [details] Proposed patch Kill all use of CoreIPC::deprecated*() in TiledDrawingArea, and put the legacy DrawingArea{,Proxy} messages to rest.
WebKit Review Bot
Comment 2 2011-06-08 09:57:25 PDT
Attachment 96436 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:118: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:119: The parameter name "updateInfo" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2011-06-08 11:07:14 PDT
Comment on attachment 96436 [details] Proposed patch Looks great! You should make sure that it builds on Windows before landing though. Thanks for working on this!
Eric Seidel (no email)
Comment 4 2011-06-09 04:05:20 PDT
Comment on attachment 96436 [details] Proposed patch Attachment 96436 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8825016
Andreas Kling
Comment 5 2011-06-09 11:16:45 PDT
Comment on attachment 96436 [details] Proposed patch Clearing flags on attachment: 96436 Committed r88463: <http://trac.webkit.org/changeset/88463>
Andreas Kling
Comment 6 2011-06-09 11:16:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.