Bug 61988

Summary: Verify cloning elements with validation messages works
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Dominic Cooney <dominicc>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61983    
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch 3 none

Dominic Cooney
Reported 2011-06-02 20:01:01 PDT
If a validation message could be cloned, it may be broken by the same cause as bug 61909.
Attachments
Patch (30.57 KB, patch)
2011-06-16 19:35 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (6.83 KB, patch)
2011-06-17 02:11 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (5.87 KB, patch)
2011-06-28 01:26 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-06-03 02:47:16 PDT
I guess cloning validation message nodes doesn't cause critical problems such as crash. However, no one won't hide a cloned validation message. Validation message nodes should not be cloned.
Kent Tamura
Comment 2 2011-06-03 03:00:51 PDT
Oops, I was wrong ;-(
Kent Tamura
Comment 3 2011-06-16 19:35:04 PDT
Created attachment 97539 [details] Patch
Hajime Morrita
Comment 4 2011-06-17 01:36:55 PDT
How about to use layoutTestController.shadowRoot() and check pseudo id for clones shadows? Another idea is to give r+ to Bug 62432, then use elementRenderTreeAsText(), which allows us a kind of reftests ;-)
Kent Tamura
Comment 5 2011-06-17 02:11:20 PDT
Created attachment 97564 [details] Patch 2 Check pseudo ID
Kent Tamura
Comment 6 2011-06-17 02:12:00 PDT
(In reply to comment #4) > How about to use layoutTestController.shadowRoot() and > check pseudo id for clones shadows? It's reasonable. Thanks!
Hajime Morrita
Comment 7 2011-06-28 01:09:41 PDT
Comment on attachment 97564 [details] Patch 2 Hi Kent-san, I'm sorry for slow response... And during my lazy time, layoutTestController.shadowRoot() is obsoleted. Could you rewrite this with window.internals.shadowRoot() ? I'm sorry again for the inconvenience.
Kent Tamura
Comment 8 2011-06-28 01:26:54 PDT
Created attachment 98881 [details] Patch 3 window.internals
WebKit Review Bot
Comment 9 2011-06-28 02:59:25 PDT
Comment on attachment 98881 [details] Patch 3 Clearing flags on attachment: 98881 Committed r89919: <http://trac.webkit.org/changeset/89919>
WebKit Review Bot
Comment 10 2011-06-28 02:59:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.