REGRESSION(84329): Stylesheets on some pages do not load

• Component: CSS
• Status: RESOLVED FIXED

[Nico Weber]

Repro:
1. Go to http://www.tbray.org/ongoing/When/201x/2011/05/23/Intimations

The page should render like it does in other browsers. Instead, it shows up without stylesheets.

I bisected, and this is caused by r84329

(This is also http://crbug.com/83786)

[Nico Weber]

Clicky: http://trac.webkit.org/changeset/84329

[Alexey Proskuryakov]

function setActiveStyleSheet(title) {
    var i, a, main;
    for (i=0; (a = document.getElementsByTagName("link")[i]); i++) {
	if (a.getAttribute("rel") &&
            a.getAttribute("rel").indexOf("style") != -1 &&
            a.getAttribute("title")) {
	    a.disabled = true;
	    if(a.getAttribute("title") == title) a.disabled = false;
	}
    }
}

[Nico Weber]

ap: Do you mean this bug should be closed WontFix?

[Julien Chaffraix]

> ap: Do you mean this bug should be closed WontFix?

FYI, the page works fine on other browsers.

Also if you click on the 'Sans Sherif' link, this calls the function ap mentioned but the style is applied correctly. It is only the 'Sherif' style sheet (the default one) that is not applied properly. I think this should be investigated before closing.

[Alexey Proskuryakov]

> ap: Do you mean this bug should be closed WontFix?

No, definitely not. This snippet looks correct.

[James Robinson]

Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web?

[Julien Chaffraix]

(In reply to comment #6)
> Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web?

I am still investigating the issue but I lean towards an incorrect implementation in this case.

[Julien Chaffraix]

Created attachment 95686 [details]
Proposed fix: Use a unified way of keeping the disabled information

[Antti Koivisto]

Comment on attachment 95686 [details]
Proposed fix: Use a unified way of keeping the disabled information

r=me

[WebKit Review Bot]

Comment on attachment 95686 [details]
Proposed fix: Use a unified way of keeping the disabled information

Clearing flags on attachment: 95686

Committed r88479: <http://trac.webkit.org/changeset/88479>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Julien Chaffraix]

Filed bug 62407 to track the 2 failures in the new test case.

[David Kilzer (:ddkilzer)]

<rdar://problem/9567255>