Bug 61034

Summary:

WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

WebCore Misc.

Assignee:

Yuta Kitamura <yutak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

35721

Attachments:

Description	Flags
Patch	none

Description Yuta Kitamura 2011-05-18 03:17:12 PDT

This is the third part of implementing WebSocket closing handshake (see bug 35721).

Remove m_pendingConnected, m_pendingMessages and m_pendingClosed from ThreadableWebSocketChannelClientWrapper, and use ScriptContext::Task to hold these pending events.

Comment 1 Yuta Kitamura 2011-05-18 03:22:57 PDT

Created attachment 93894 [details]
Patch

Comment 2 Kent Tamura 2011-05-18 18:39:35 PDT

Comment on attachment 93894 [details]
Patch

Looks good.

Comment 3 WebKit Commit Bot 2011-05-19 02:31:19 PDT

The commit-queue encountered the following flaky tests while processing attachment 93894 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.

Comment 4 WebKit Commit Bot 2011-05-19 02:33:28 PDT

Comment on attachment 93894 [details]
Patch

Clearing flags on attachment: 93894

Committed r86829: <http://trac.webkit.org/changeset/86829>

Comment 5 WebKit Commit Bot 2011-05-19 02:33:31 PDT

All reviewed patches have been landed.  Closing bug.