Summary: | WebSocket: Add CLOSING state | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||||||
Component: | WebCore Misc. | Assignee: | Yuta Kitamura <yutak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap, commit-queue, mjs, tkent | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 60880 | ||||||||||
Bug Blocks: | 35721 | ||||||||||
Attachments: |
|
Description
Yuta Kitamura
2011-05-16 02:48:59 PDT
Created attachment 93630 [details]
Patch
Comment on attachment 93630 [details]
Patch
r- because of EWS failures.
The EWS failure is not a fault of this patch. LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply. So, it sounds like another yak to shave... (In reply to comment #3) > The EWS failure is not a fault of this patch. > > LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply. I see. Anyway, you need to update LayoutTests/qt/fast/dom/Window/window-properties-expected.txt too. Created attachment 93635 [details]
Patch v2 (Add expected result for Qt)
Comment on attachment 93635 [details]
Patch v2 (Add expected result for Qt)
ok
Created attachment 93746 [details]
Ready to commit
(In reply to comment #7) > Created an attachment (id=93746) [details] > Ready to commit I'd like to see the results of EWS bots before committing. The commit-queue encountered the following flaky tests while processing attachment 93746 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) http/tests/appcache/cyrillic-uri.html bug 61020 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 93746 [details] Ready to commit Clearing flags on attachment: 93746 Committed r86732: <http://trac.webkit.org/changeset/86732> All reviewed patches have been landed. Closing bug. |