Bug 60679

Summary: Switch paintBoxDecorationWithSize to IntRect
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60408, 60578    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-05-11 17:40:28 PDT
Another four-ints-but-should-be-an-IntRect offender.
Attachments
Patch (3.85 KB, patch)
2011-05-12 15:08 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-12 15:08:08 PDT
Created attachment 93351 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-12 15:10:25 PDT
Comment on attachment 93351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93351&action=review > Source/WebCore/rendering/RenderBox.cpp:808 > + if (paintInfo.shouldPaintWithinRoot(this)) > + paintBoxDecorationsWithSize(paintInfo, IntRect(tx, ty, width(), height())); I think I like the other style better. But it doesn't really matter. :)
Levi Weintraub
Comment 3 2011-05-12 15:15:30 PDT
Comment on attachment 93351 [details] Patch Clearing flags on attachment: 93351 Committed r86385: <http://trac.webkit.org/changeset/86385>
Levi Weintraub
Comment 4 2011-05-12 15:15:33 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2011-05-12 17:24:29 PDT
const IntRect&!
Eric Seidel (no email)
Comment 6 2011-05-12 19:00:26 PDT
(In reply to comment #5) > const IntRect&! Oops. Sorry. :(
Note You need to log in before you can comment on or make changes to this bug.