Bug 60554

Summary: Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
Product: WebKit Reporter: Chang Shu <cshu>
Component: HTML EditingAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 59534, 60477    
Attachments:
Description Flags
fix patch
darin: review+
fix patch 2: set allow-tabs for expected file none

Chang Shu
Reported 2011-05-10 08:49:08 PDT
The above test can be converted to to dumpAsText.
Attachments
fix patch (8.82 KB, patch)
2011-05-10 08:52 PDT, Chang Shu 		darin: review+
DetailsFormatted DiffDiff
fix patch 2: set allow-tabs for expected file (9.00 KB, patch)
2011-05-10 09:19 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-05-10 08:52:34 PDT
Created attachment 92960 [details] fix patch
Darin Adler
Comment 2 2011-05-10 09:01:59 PDT
Comment on attachment 92960 [details] fix patch Looks fine. You may have trouble landing this without sending the “allow tabs” Subversion property on the expected file.
Chang Shu
Comment 3 2011-05-10 09:19:54 PDT
Created attachment 92965 [details] fix patch 2: set allow-tabs for expected file
Chang Shu
Comment 4 2011-05-10 09:20:51 PDT
(In reply to comment #2) > (From update of attachment 92960 [details]) > Looks fine. You may have trouble landing this without sending the “allow tabs” Subversion property on the expected file. thanks for the review, Darin. I updated the patch. Hopefully I am doing it the right way.
WebKit Commit Bot
Comment 5 2011-05-10 10:36:51 PDT
Comment on attachment 92965 [details] fix patch 2: set allow-tabs for expected file Clearing flags on attachment: 92965 Committed r86166: <http://trac.webkit.org/changeset/86166>
WebKit Commit Bot
Comment 6 2011-05-10 10:36:57 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 7 2011-05-16 14:04:51 PDT
Revision r86166 cherry-picked into qtwebkit-2.2 with commit abec9ee <http://gitorious.org/webkit/qtwebkit/commit/abec9ee>
Note You need to log in before you can comment on or make changes to this bug.