Bug 60554 - Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
Summary: Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 59534 60477
  Show dependency tree / graph
 
Reported: 2011-05-10 08:49 PDT by Chang Shu
Modified: 2011-05-16 14:04 PDT (History)
3 users (show)

See Also:

Attachments
fix patch (8.82 KB, patch)
2011-05-10 08:52 PDT, Chang Shu 		darin: review+
Details | Formatted Diff | Diff
fix patch 2: set allow-tabs for expected file (9.00 KB, patch)
2011-05-10 09:19 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-05-10 08:49:08 PDT 
The above test can be converted to to dumpAsText.
Comment 1 Chang Shu 2011-05-10 08:52:34 PDT 
Created attachment 92960 [details]
fix patch
Comment 2 Darin Adler 2011-05-10 09:01:59 PDT 
Comment on attachment 92960 [details]
fix patch

Looks fine. You may have trouble landing this without sending the “allow tabs” Subversion property on the expected file.
Comment 3 Chang Shu 2011-05-10 09:19:54 PDT 
Created attachment 92965 [details]
fix patch 2: set allow-tabs for expected file
Comment 4 Chang Shu 2011-05-10 09:20:51 PDT 
(In reply to comment #2)
> (From update of attachment 92960 [details])
> Looks fine. You may have trouble landing this without sending the “allow tabs” Subversion property on the expected file.

thanks for the review, Darin. I updated the patch. Hopefully I am doing it the right way.
Comment 5 WebKit Commit Bot 2011-05-10 10:36:51 PDT 
Comment on attachment 92965 [details]
fix patch 2: set allow-tabs for expected file

Clearing flags on attachment: 92965

Committed r86166: <http://trac.webkit.org/changeset/86166>
Comment 6 WebKit Commit Bot 2011-05-10 10:36:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Ademar Reis 2011-05-16 14:04:51 PDT 
Revision r86166 cherry-picked into qtwebkit-2.2 with commit abec9ee <http://gitorious.org/webkit/qtwebkit/commit/abec9ee>