Summary: | IndexedDB: fix up database-quota.html layout test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||
Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric, hans, japhet | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Grogan
2011-05-09 17:30:49 PDT
Created attachment 92891 [details]
Patch
Unofficial r+. Who generally reviews database patches? Comment on attachment 92891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > -Error function called: (undefined) undefined > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch. (In reply to comment #4) > (From update of attachment 92891 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92891&action=review > > > LayoutTests/storage/indexeddb/database-quota-expected.txt:28 > > -Error function called: (undefined) undefined > > +FAIL Error function called: (13) The transaction was aborted, so the request cannot be fulfilled. > > Is this test genuinely failing, or is this error the correct behavior? I can't tell just from this patch. The error is the correct behavior, so it probably shouldn't go in a testFailed. Will re-upload. Created attachment 93302 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 93302 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/appcache/resource-redirect.html bug 60714 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 93302 [details] Patch Clearing flags on attachment: 93302 Committed r86363: <http://trac.webkit.org/changeset/86363> All reviewed patches have been landed. Closing bug. |