| Summary: | [Chromium] Add rebaseline images for video-controls-rendering. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | imasaki | ||||||||
| Component: | New Bugs | Assignee: | imasaki | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, jianli, levin, vrk | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
imasaki
2011-05-09 16:47:19 PDT
Created attachment 92885 [details]
Patch
Created attachment 92887 [details]
Patch
Comment on attachment 92887 [details] Patch The ChangeLog really doesn't provide enough information here. It points to this bug http://code.google.com/p/chromium/issues/detail?id=74102 but that bug isn't fixed. Are we checking in a bad baseline so that we ensure no other problems occur (while bug 74102 is being fixed)? This information would be helpful in the ChangeLog. (In general the ChangeLog should explain why this change is being done.) Created attachment 92895 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 92895 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 92895 [details] Patch Clearing flags on attachment: 92895 Committed r86121: <http://trac.webkit.org/changeset/86121> All reviewed patches have been landed. Closing bug. |