Bug 60408
| Summary: | [meta] Replace uses of tx/ty with IntSize | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Levi Weintraub <leviw> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | eae, eric, hyatt, jamesr, leviw, mjs |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://lists.webkit.org/pipermail/webkit-dev/2010-August/thread.html#13968 | ||
| Bug Depends on: | 60490, 60578, 60679 | ||
| Bug Blocks: | 60318 | ||
Levi Weintraub
tx/ty offsets used in painting are confusing and should be combined into either an IntSize or IntPoint -- likely IntSize. See the URL for a related discussion from WebKit-Dev.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Levi Weintraub
Considering how frequently tx/ty are used to construct points AND sizes, I now feel like this could warrant a new type to avoid the mess of calling this an point or size then repeatedly using it another way. Perhaps PaintOffset/IntOffset, which would allow easy conversion to points and sizes.
Levi Weintraub
Updating with the name and making this a meta bug to track all the changes that'll help us make this switch.
Levi Weintraub
We already have a metabug tracking this work, and we ended up using IntPoint instead of IntSize.